'Thoughts on editor disappearing issues'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Thoughts on editor disappearing issues
From:       Hamish Rodda <rodda () kde ! org>
Date:       2008-06-12 1:48:45
Message-ID: 200806121148.45685.rodda () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi,

The problem: if the user closes the document while duchain parsing is 
occurring, the text editor will be deleted and may be accessed after deletion.

At this point, we should probably dump all smart ranges and switch to non-
smart range parsing, however the file that was just closed may be modified and 
not saved to disk, so ideally we just need to throw out that parse session and 
do it again from disk.

Seeing as this covers a large body of code, should we thow an exception in the 
editor integrator, and catch them outside of the duchain parsing (ie. in the 
parse job).  Then, the parse job can try again from disk.

Does that sound like a good solution?

Cheers,
Hamish.

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Bitstream Vera Sans'; font-size:10pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">Hi,</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">The problem: if the user closes the document \
while duchain parsing is occurring, the text editor will be deleted and may be \
accessed after deletion.</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">At this point, we should probably dump all smart \
ranges and switch to non-smart range parsing, however the file that was just closed \
may be modified and not saved to disk, so ideally we just need to throw out that \
parse session and do it again from disk.</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Seeing as this covers a large \
body of code, should we thow an exception in the editor integrator, and catch them \
outside of the duchain parsing (ie. in the parse job).  Then, the parse job can try \
again from disk.</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">Does that sound like a good solution?</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Cheers,</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Hamish.</p></body></html>

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 