From kde-release-team Sun Nov 08 13:04:41 2020 From: Allen Winter Date: Sun, 08 Nov 2020 13:04:41 +0000 To: kde-release-team Subject: Re: KDE Frameworks 5.76.0 Message-Id: <5409444.DvuYhMxLoT () zazzy> X-MARC-Message: https://marc.info/?l=kde-release-team&m=160484069908827 Revert completed. @Damien: yes please. add a conditional compile check for libical 3.0.5 (bet= ter double-check that version) On Sunday, November 8, 2020 4:26:38 AM EST Caliste Damien wrote: > Hello, >=20 > Le samedi 07 novembre 2020, Allen Winter a =E9crit : > > > Allen, what's the minimum version? > > > =20 > > libical 3.0.5 > >=20 > > Oh. kinda my fault. > > I approved c5d7bc89c7da527c58967231e9c0ac75c331cdb1 in kcalendarcore > > without considering that the min libical version would need to be > > bumped. > My bad to propose a MR without paying attention to the required library > version. I'm sorry, I'll be more cautious next time. >=20 > > libical 3.0.5 was released 1.5 years ago (May 2019). Not that old. > >=20 > > Objections if I revert c5d7bc89c7da527c58967231e9c0ac75c331cdb1 > > and we can do a conditional compile for frameworks 5.77? > No problem, you can revert it, I'll propose a new one with version > check, if you agree. >=20