[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: 2 kirigami fixes for a point release
From:       David Faure <faure () kde ! org>
Date:       2020-03-20 19:37:20
Message-ID: 3289003.V25eIC5XRa () asterixp50
[Download RAW message or body]

On vendredi 20 mars 2020 12:16:09 CET David Edmundson wrote:
> >> > Kirigami seems to be rather unstable, I wonder if anything can be done
> >> > to
> >> > improve upon that [*].
> >> 
> >> One important thing seems to have been getting sloppy in those repos;
> >> mandatory code reviews.
> >> That's an easy thing to enforce, and we know it makes a huge difference
> >> to
> >> code.
> >> 
> >> Even if no-one comments, the extra delay of it running on your own
> >> system delivers a lot.
> >
> >I fully agree.
> >
> >(CC'ing the developer lists)
> 
> The situation with code reviews has not changed.
> 
>  git log --grep Differential --invert-grep  --since 1.month
> 
> In Kirigami is extremely disappointing, and not something we see in
> other frameworks.

Thanks for noticing (and for the nice git command line!).

I'm going to ask more directly than the other David dares doing...

@Marco, can you please start using phabricator for all your commits, so that 
they get reviewed?

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



[prev in list] [next in list] [prev in thread] [next in thread]