[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: KDE Applications 19.04.3 packages available for packagers
From:       Jonathan Riddell <jr () jriddell ! org>
Date:       2019-07-18 15:24:54
Message-ID: CANX=XXMpmjkwfGiL8x6f6tDgj3NaRtgFt7KNgSxCajtF324qnA () mail ! gmail ! com
[Download RAW message or body]

On Fri, 12 Jul 2019 at 15:01, Daniel Vrátil <dvratil@kde.org> wrote:

> > This shouldn't be done in a bugfix release
>
> Sorry about this, I had no idea this change would affect Apparmor. This
> was a
> bugfix for MacOS where the socket path was simply too long.
>
> At the same time, you cannot assume all maintainers know about all such
> 3rd
> party software and know what changes might or might not affect it.  Maybe
> if
> the Apparmor config file for Akonadi was in the Akonadi repo and I knew
> about
> it, it would hit a bell in my head while doing the codereview for this
> change.
> But this way, even if I knew Apparmor would be affected by this change, I
> have
> no clue where to look for...whatever I have to look for in order to do or
> ask
> for the adjustments.
>
> IMO since this is something you do in your packaging and is outside of
> upstream control, it's something you should check before pushing the
> package
> to your users, not blaming upstream for breaking your distro "patches".
>

Fair points, sorry I sounded blaming.

Any other distros out there use an apparmour profile?  Can we get it
upstream into akonadi directly?

https://packaging.neon.kde.org/kde/akonadi.git/tree/debian/usr.sbin.mysqld-akonadi?h=Neon/release-lts

Jonathan

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr">On Fri, 12 Jul 2019 at 15:01, Daniel Vrátil &lt;<a \
href="mailto:dvratil@kde.org">dvratil@kde.org</a>&gt; wrote:<br></div><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">&gt; This \
shouldn&#39;t be done in a bugfix release<br> <br>
Sorry about this, I had no idea this change would affect Apparmor. This was a <br>
bugfix for MacOS where the socket path was simply too long.<br>
<br>
At the same time, you cannot assume all maintainers know about all such 3rd <br>
party software and know what changes might or might not affect it.   Maybe if <br>
the Apparmor config file for Akonadi was in the Akonadi repo and I knew about <br>
it, it would hit a bell in my head while doing the codereview for this change. <br>
But this way, even if I knew Apparmor would be affected by this change, I have <br>
no clue where to look for...whatever I have to look for in order to do or ask <br>
for the adjustments.<br>
<br>
IMO since this is something you do in your packaging and is outside of <br>
upstream control, it&#39;s something you should check before pushing the package <br>
to your users, not blaming upstream for breaking your distro \
&quot;patches&quot;.<br></blockquote><div><br></div><div>Fair points, sorry I sounded \
blaming. <br></div><div><br></div><div>Any other distros out there use an apparmour \
profile?   Can we get it upstream into akonadi directly?</div><div><br></div><div><a \
href="https://packaging.neon.kde.org/kde/akonadi.git/tree/debian/usr.sbin.mysqld-akona \
di?h=Neon/release-lts">https://packaging.neon.kde.org/kde/akonadi.git/tree/debian/usr. \
sbin.mysqld-akonadi?h=Neon/release-lts</a></div><div><br></div><div>Jonathan</div><div><br></div><div><br></div><div><br></div><div> \
</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]