[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.
From: "Boudhayan Gupta" <bgupta () kde ! org>
Date: 2015-10-09 20:36:11
Message-ID: 20151009203611.17685.33553 () mimi ! kde ! org
[Download RAW message or body]
--===============7835769037954955435==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 10, 2015, 12:58 a.m., Boudhayan Gupta wrote:
> > src/lib/searchstore.cpp, line 126
> > <https://git.reviewboard.kde.org/r/125544/diff/2/?file=410375#file410375line126>
> >
> > Shouldn't this be qMin(size, offset + limit)?
>
> Vishesh Handa wrote:
> I don't think it matters.
>
> If there aren't any more elements then `it->next()` will be false.
Ah, right. Silly me.
I'm dropping the issue.
- Boudhayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125544/#review86568
-----------------------------------------------------------
On Oct. 10, 2015, 12:27 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125544/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 12:27 a.m.)
>
>
> Review request for Baloo, Release Team and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> The bug is obvious, old code uses limit instead of (limit > 0), which gracefully \
> handles limit < 0 case (means everything).
> After offset is introduced, limit < 0 case is not handled properly.
>
> This patch contains following changes:
> 1. make offset uint, m_offset is uint in Query already.
> 2. handle limit < 0 case properly.
>
> Also fix offset with sorting.
>
>
> Diffs
> -----
>
> src/lib/searchstore.h 17b4263
> src/lib/searchstore.cpp a2e7749
>
> Diff: https://git.reviewboard.kde.org/r/125544/diff/
>
>
> Testing
> -------
>
> baloosearch:/ doesn't return anything because of this, now it properly returns \
> result.
> Play with baloosearch command a little bit, offset and limit returns the [offset, \
> offset + limit) and no crash on the border case.
>
> Thanks,
>
> Xuetian Weng
>
>
--===============7835769037954955435==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125544/">https://git.reviewboard.kde.org/r/125544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 10th, 2015, 12:58 a.m. IST, \
<b>Boudhayan Gupta</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125544/diff/2/?file=410375#file410375line126" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/searchstore.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QStringList SearchStore::exec(const Term& term, int offset, int limit, bool \
sortResults)</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; ">QStringList SearchStore::exec(const Term& term, uint offset, \
int limit, bool sortResults)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">117</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">while</span> <span class="p">(</span><span class="n">it</span><span \
class="o">-></span><span class="n">next</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">limit</span> <span class="o">></span> \
<span class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">122</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">uint</span> <span class="n">end</span> <span \
class="o">=</span> <span class="n">offset</span> <span class="o">+</span> <span \
class="k">static_cast</span><span class="o"><</span><span \
class="n">uint</span><span class="o">></span><span class="p">(</span><span \
class="n">limit</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shouldn't this be qMin(size, offset + limit)?</p></pre> </blockquote>
<p>On October 10th, 2015, 1:07 a.m. IST, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think it matters.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If there aren't any more elements then \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">it->next()</code> will be false.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ah, right. Silly me.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm dropping the \
issue.</p></pre> <br />
<p>- Boudhayan</p>
<br />
<p>On October 10th, 2015, 12:27 a.m. IST, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo, Release Team and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2015, 12:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The bug is obvious, old code uses limit instead of \
(limit > 0), which gracefully handles limit < 0 case (means everything).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">After offset is introduced, limit < 0 case is not handled properly.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch contains following changes: 1. make offset \
uint, m_offset is uint in Query already. 2. handle limit < 0 case properly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also fix offset with sorting.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">baloosearch:/ doesn't return anything because of this, \
now it properly returns result.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Play with baloosearch \
command a little bit, offset and limit returns the [offset, offset + limit) and no \
crash on the border case.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/searchstore.h <span style="color: grey">(17b4263)</span></li>
<li>src/lib/searchstore.cpp <span style="color: grey">(a2e7749)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7835769037954955435==--
[Attachment #3 (text/plain)]
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic