'Re: Review Request 122868: Add runtime-only dependency to ktp-auth-handler'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 122868: Add runtime-only dependency to ktp-auth-handler
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-03-11 16:20:32
Message-ID: 20150311162032.3786.11559 () mimi ! kde ! org
[Download RAW message or body]

--===============2619724716164910433==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122868/
-----------------------------------------------------------

(Updated March 11, 2015, 4:20 p.m.)

Status
------

This change has been marked as submitted.

Review request for Release Team and Harald Sitter.

Changes
-------

Submitted with commit 507e1518d478b9c7942c40fd0a69c417a2c330cf by Martin Klapetek to \
branch Applications/15.04.

Repository: ktp-auth-handler

Description
-------

There is already a big warning in ktp-auth-handler about the need of qca-ossl plugin \
during runtime. But according to packagers this can easily get missed and is not \
machine parseable and I was suggested to rather do it this way.

Technically this does not add any new dependency, it just marks existing runtime \
dependencies in a better way and makes life easier for packagers.

Diffs
-----

  CMakeLists.txt e5a66c0 

Diff: https://git.reviewboard.kde.org/r/122868/diff/

Testing
-------

Thanks,

Martin Klapetek

--===============2619724716164910433==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122868/">https://git.reviewboard.kde.org/r/122868/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Release Team and Harald Sitter.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated March 11, 2015, 4:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 507e1518d478b9c7942c40fd0a69c417a2c330cf by Martin \
Klapetek to branch Applications/15.04.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-auth-handler
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is already a big warning in ktp-auth-handler \
about the need of qca-ossl plugin during runtime. But according to packagers this can \
easily get missed and is not machine parseable and I was suggested to rather do it \
this way.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Technically this does not add any new dependency, it \
just marks existing runtime dependencies in a better way and makes life easier for \
packagers.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(e5a66c0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122868/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2619724716164910433==--

[Attachment #3 (text/plain)]

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 