'Re: Review Request 119915: Plasma release scripts to use Ki18n's PO installation macro'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 119915: Plasma release scripts to use Ki18n's PO installation macro
From:       "Chusslove Illich" <caslav.ilic () gmx ! net>
Date:       2014-09-01 18:49:17
Message-ID: 20140901184917.11808.95961 () probe ! kde ! org
[Download RAW message or body]

--===============7546250547916071347==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119915/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 6:49 p.m.)

Status
------

This change has been marked as submitted.

Review request for Release Team, Jonathan Riddell and Harald Sitter.

Repository: releaseme

Description
-------

At present, for installing Plasma PO files the release scripts create CMakeLists.txt \
files inside po/ directory, which use CMake's GETTEXT_PROCESS_PO_FILES. Ki18n instead \
provides the KI18N_INSTALL macro that only needs to be called once from the top \
CMakeLists.txt, with po directory as argument. This patch switches to using it.

This is in preparation for updating release scripts to also fetch translation \
scripting modules into the packages. Every PO file can have an associated scripting \
module (though they are rare). KI18N_INSTALL handles these modules as well, when they \
are found in expected location inside po/ directory.

Diffs
-----

  lib/cmakeeditor.rb 03ebac0 
  lib/kdel10n.rb f855de8 
  lib/tests/ts_cmakeeditor.rb 9d7339f 
  lib/tests/ts_l10n.rb 1a328a3 

Diff: https://git.reviewboard.kde.org/r/119915/diff/

Testing
-------

Run tarme.rb on couple of modules and languages, CMakeLists.txt tree got updated as \
expected. Run ts_cmakeeditor.rb.

Thanks,

Chusslove Illich

--===============7546250547916071347==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119915/">https://git.reviewboard.kde.org/r/119915/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Release Team, Jonathan Riddell and Harald Sitter.</div>
<div>By Chusslove Illich.</div>

<p style="color: grey;"><i>Updated Sept. 1, 2014, 6:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
releaseme
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At present, for installing Plasma PO files the release \
scripts create CMakeLists.txt files inside po/ directory, which use CMake's \
GETTEXT_PROCESS_PO_FILES. Ki18n instead provides the KI18N_INSTALL macro that only \
needs to be called once from the top CMakeLists.txt, with po directory as argument. \
This patch switches to using it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is in preparation \
for updating release scripts to also fetch translation scripting modules into the \
packages. Every PO file can have an associated scripting module (though they are \
rare). KI18N_INSTALL handles these modules as well, when they are found in expected \
location inside po/ directory.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Run tarme.rb on couple of modules and languages, \
CMakeLists.txt tree got updated as expected. Run ts_cmakeeditor.rb.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/cmakeeditor.rb <span style="color: grey">(03ebac0)</span></li>

 <li>lib/kdel10n.rb <span style="color: grey">(f855de8)</span></li>

 <li>lib/tests/ts_cmakeeditor.rb <span style="color: grey">(9d7339f)</span></li>

 <li>lib/tests/ts_l10n.rb <span style="color: grey">(1a328a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119915/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7546250547916071347==--

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 