[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 111707: Export the value of lidAction (in handleButtonEvents action)
From:       "Commit Hook" <null () kde ! org>
Date:       2013-08-05 13:11:16
Message-ID: 20130805131116.18451.31902 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111707/#review37125
-----------------------------------------------------------


This review has been submitted with commit c87092f96af41105953ae3ba7568b95921acfd4f \
by Àlex Fiestas to branch KDE/4.11.

- Commit Hook


On Aug. 1, 2013, 7:47 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111707/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 7:47 p.m.)
> 
> 
> Review request for Release Team, Solid, Kai Uwe Broulik, Dario Freddi, and Oliver \
> Henshaw. 
> 
> Description
> -------
> 
> We need to know this value in kscreen so we can act in consequence. We discussed \
> this in the sprint already and everybody was ok. 
> Release team, can we push this to 4.11? it only exports a value on the bus using a \
> established and standard way of doing it (we use this in 4 more places, exact \
> code). 
> 
> Diffs
> -----
> 
> powerdevil/daemon/CMakeLists.txt d0274eb 
> powerdevil/daemon/actions/bundled/handlebuttonevents.h a16feba 
> powerdevil/daemon/actions/bundled/handlebuttonevents.cpp 78e1d27 
> powerdevil/daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop \
> 82f3e1b  
> Diff: http://git.reviewboard.kde.org/r/111707/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111707/">http://git.reviewboard.kde.org/r/111707/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c87092f96af41105953ae3ba7568b95921acfd4f by Àlex Fiestas to \
branch KDE/4.11.</pre>  <br />









<p>- Commit</p>


<br />
<p>On August 1st, 2013, 7:47 p.m. UTC, Àlex Fiestas wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Release Team, Solid, Kai Uwe Broulik, Dario Freddi, and \
Oliver Henshaw.</div> <div>By Àlex Fiestas.</div>


<p style="color: grey;"><i>Updated Aug. 1, 2013, 7:47 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We need to know this value in kscreen so we can act in consequence. We \
discussed this in the sprint already and everybody was ok.

Release team, can we push this to 4.11? it only exports a value on the bus using a \
established and standard way of doing it (we use this in 4 more places, exact \
code).</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>powerdevil/daemon/CMakeLists.txt <span style="color: grey">(d0274eb)</span></li>

 <li>powerdevil/daemon/actions/bundled/handlebuttonevents.h <span style="color: \
grey">(a16feba)</span></li>

 <li>powerdevil/daemon/actions/bundled/handlebuttonevents.cpp <span style="color: \
grey">(78e1d27)</span></li>

 <li>powerdevil/daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop \
<span style="color: grey">(82f3e1b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111707/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic