[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 111768: Replace Notification by kWarning on missing/unsupported action
From: "Dario Freddi" <drf () kde ! org>
Date: 2013-07-29 7:22:04
Message-ID: 20130729072204.16921.16274 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111768/#review36703
-----------------------------------------------------------
Ship it!
No objection - in the longer run, we should definitely rework that part.
- Dario Freddi
On July 28, 2013, 11:01 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111768/
> -----------------------------------------------------------
>
> (Updated July 28, 2013, 11:01 p.m.)
>
>
> Review request for Release Team, Solid and Dario Freddi.
>
>
> Description
> -------
>
> In 4.11 we are able to detect if an action is supported or not, and if it is not we \
> simply unload it.
> That new behavior makes the notification "Action not found" deprecated since now it \
> is totally possible that a profile tries to load an unsupported action such \
> DimDisplay on most workstations.
> In Powerdevil2/Plasma2/Whatev perhaps we should remove the action from the config, \
> but I'm not sure because an action might be supported during a period of time, for \
> example when plugging a keyboard that support backlight, so it looks to me that we \
> need something more dyamic.
> Release team: This removes a line from the catalog.
>
> https://bugs.kde.org/show_bug.cgi?id=321508
> https://bugs.kde.org/show_bug.cgi?id=302846
>
>
> Diffs
> -----
>
> powerdevil/daemon/powerdevilcore.cpp 6874feb
>
> Diff: http://git.reviewboard.kde.org/r/111768/diff/
>
>
> Testing
> -------
>
> Notification is not emit anymore.
>
>
> Thanks,
>
> Àlex Fiestas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111768/">http://git.reviewboard.kde.org/r/111768/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No objection - in the \
longer run, we should definitely rework that part.</pre> <br />
<p>- Dario</p>
<br />
<p>On July 28th, 2013, 11:01 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Release Team, Solid and Dario Freddi.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated July 28, 2013, 11:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In 4.11 we are able to detect if an action is supported or not, and if \
it is not we simply unload it.
That new behavior makes the notification "Action not found" deprecated \
since now it is totally possible that a profile tries to load an unsupported action \
such DimDisplay on most workstations.
In Powerdevil2/Plasma2/Whatev perhaps we should remove the action from the config, \
but I'm not sure because an action might be supported during a period of time, \
for example when plugging a keyboard that support backlight, so it looks to me that \
we need something more dyamic.
Release team: This removes a line from the catalog.
https://bugs.kde.org/show_bug.cgi?id=321508
https://bugs.kde.org/show_bug.cgi?id=302846</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Notification is not emit anymore.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: \
grey">(6874feb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111768/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic