[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    [kde-workspace] kwin: clear m_activeEffects when effects change
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-05-04 9:57:13
Message-ID: 20130504095713.729B3A6048 () git ! kde ! org
[Download RAW message or body]

Git commit ad4b7cfa0ef1c935235071c9bda9196ad7c12239 by Thomas Lübking.
Committed on 03/05/2013 at 23:12.
Pushed by luebking into branch 'master'.

clear m_activeEffects when effects change

If a screen with different refreshrate is attached, kwin currently resets
the compositor, altering the effect list.
If at the same time quads are rebuilt, the iteration operates on a pot.
invalid list of dangeling active effects.

Many thanks to Toralf Förster for his testing efforts.

BUG: 308201
FIXED-IN: 4.10.3
REVIEW: 110294
CC: release-team@kde.org
(cherry picked from commit 07d3ac9d8c781755d19c71ccde6d182868a2bfb5)

M  +1    -0    kwin/effects.cpp

http://commits.kde.org/kde-workspace/ad4b7cfa0ef1c935235071c9bda9196ad7c12239

diff --git a/kwin/effects.cpp b/kwin/effects.cpp
index 073c9f8..f45d81b 100644
--- a/kwin/effects.cpp
+++ b/kwin/effects.cpp
@@ -1527,6 +1527,7 @@ void EffectsHandlerImpl::reloadEffect(Effect *effect)
 void EffectsHandlerImpl::effectsChanged()
 {
     loaded_effects.clear();
+    m_activeEffects.clear(); // it's possible to have a reconfigure and a quad \
rebuild between two paint cycles - bug #308201  //    kDebug(1212) << "Recreating \
effects' list:";  foreach (const EffectPair & effect, effect_order) {
 //        kDebug(1212) << effect.first;
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]