'Re: Review Request 108516: Do not hardcode site-packages for the python libdir.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-24 14:48:18
Message-ID: 20130124144818.27699.32915 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108516/#review26132
-----------------------------------------------------------

This review has been submitted with commit feabe372895048b41679ceabf34e189ef8edd69b \
by Michael Jansen to branch KDE/4.10.

- Commit Hook

On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108516/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 7:28 p.m.)
> 
> 
> Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, \
> and Luca Beltrame. 
> 
> Description
> -------
> 
> Do not hardcode site-packages for the python libdir.
> 
> 
> Diffs
> -----
> 
> cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 
> 
> Diff: http://git.reviewboard.kde.org/r/108516/diff/
> 
> 
> Testing
> -------
> 
> Not much. Works the same as before. Need someone to check on debian. Need someone \
> to check when installing into /usr. 
> I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from \
> PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be \
> a trailing slash or different case on windows. Any hints to improve it? 
> 
> Thanks,
> 
> Michael Jansen
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108516/">http://git.reviewboard.kde.org/r/108516/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit feabe372895048b41679ceabf34e189ef8edd69b by Michael Jansen to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 22nd, 2013, 7:28 p.m. UTC, Michael Jansen wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Build System, Release Team, Christophe Giboudeaux, Kevin \
Kofler, and Luca Beltrame.</div> <div>By Michael Jansen.</div>

<p style="color: grey;"><i>Updated Jan. 22, 2013, 7:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not hardcode site-packages for the python libdir.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not much. Works the same as before. Need someone to check on debian. \
Need someone to check when installing into /usr.

I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from \
PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a \
trailing slash or different case on windows. Any hints to improve it?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindPythonLibrary.cmake <span style="color: \
grey">(7cef79b16521c759f38f1deea539a28a50c5d708)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108516/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 