'Re: Review Request: Do no depend on kdelibs Nepomuk'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request: Do no depend on kdelibs Nepomuk
From:       "Albert Astals Cid" <tsdgeos () terra ! es>
Date:       2012-07-31 20:28:08
Message-ID: 20120731202808.26626.28788 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105766/#review16722
-----------------------------------------------------------

Spoke with Vishesh and Patrick, this patch is correct but does not need 4.9=
.0 tarballs respinning.

- Albert Astals Cid

On July 28, 2012, 12:09 p.m., Vishesh Handa wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105766/
> -----------------------------------------------------------
> =

> (Updated July 28, 2012, 12:09 p.m.)
> =

> =

> Review request for Nepomuk, Release Team, Patrick Spendrin, and Sebastian=
 Trueg.
> =

> =

> Description
> -------
> =

>     Do no depend on kdelibs Nepomuk
>     =

>     * Removed find_package(Nepomuk REQUIRED), and other unnecessary comma=
nds
>     * We do not need to include NEPOMUK_INCLUDE_DIR in the list of includ=
es
> =

> @Release-Team: Apparently needed for Windows.
> =

> =

> Diffs
> -----
> =

>   server/CMakeLists.txt 9635f22 =

>   services/backupsync/gui/CMakeLists.txt 02800d3 =

>   services/backupsync/gui/guitest/CMakeLists.txt 146ba3a =

>   services/backupsync/lib/CMakeLists.txt 769a116 =

>   services/backupsync/lib/test/CMakeLists.txt 55d0af7 =

>   services/backupsync/service/CMakeLists.txt 6fa785c =

>   services/fileindexer/CMakeLists.txt 60d9b36 =

>   services/fileindexer/indexer/CMakeLists.txt 38b46c8 =

>   services/fileindexer/test/CMakeLists.txt 4e66e7b =

>   services/filewatch/CMakeLists.txt fd5d710 =

>   services/storage/test/CMakeLists.txt cbef45e =

>   servicestub/CMakeLists.txt 88b24aa =

> =

> Diff: http://git.reviewboard.kde.org/r/105766/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Vishesh Handa
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105766/">http://git.reviewboard.kde.org/r/105766/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Spoke with Vishesh and \
Patrick, this patch is correct but does not need 4.9.0 tarballs respinning.</pre>  \
<br />

<p>- Albert</p>

<br />
<p>On July 28th, 2012, 12:09 p.m., Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Release Team, Patrick Spendrin, and Sebastian \
Trueg.</div> <div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 28, 2012, 12:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Do no depend on kdelibs Nepomuk  
    * Removed find_package(Nepomuk REQUIRED), and other unnecessary commands
    * We do not need to include NEPOMUK_INCLUDE_DIR in the list of includes

@Release-Team: Apparently needed for Windows.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/CMakeLists.txt <span style="color: grey">(9635f22)</span></li>

 <li>services/backupsync/gui/CMakeLists.txt <span style="color: \
grey">(02800d3)</span></li>

 <li>services/backupsync/gui/guitest/CMakeLists.txt <span style="color: \
grey">(146ba3a)</span></li>

 <li>services/backupsync/lib/CMakeLists.txt <span style="color: \
grey">(769a116)</span></li>

 <li>services/backupsync/lib/test/CMakeLists.txt <span style="color: \
grey">(55d0af7)</span></li>

 <li>services/backupsync/service/CMakeLists.txt <span style="color: \
grey">(6fa785c)</span></li>

 <li>services/fileindexer/CMakeLists.txt <span style="color: \
grey">(60d9b36)</span></li>

 <li>services/fileindexer/indexer/CMakeLists.txt <span style="color: \
grey">(38b46c8)</span></li>

 <li>services/fileindexer/test/CMakeLists.txt <span style="color: \
grey">(4e66e7b)</span></li>

 <li>services/filewatch/CMakeLists.txt <span style="color: \
grey">(fd5d710)</span></li>

 <li>services/storage/test/CMakeLists.txt <span style="color: \
grey">(cbef45e)</span></li>

 <li>servicestub/CMakeLists.txt <span style="color: grey">(88b24aa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105766/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 