[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: Use nao:iconName for icons instead of nao:prefLabel
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2012-07-30 18:22:29
Message-ID: 20120730182229.24989.82823 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 30, 2012, 6:07 p.m., Albert Astals Cid wrote:
> > What's the outcome for 4.9.0 if we do not get this in?
> =
> Vishesh Handa wrote:
> Nothing drastic. Internal database stuff. Makes very little differenc=
e if it goes into 4.9 or 4.9.1 or 4.10.
> =
> Nothing user visible. I currently handle both cases in the user inter=
face.
If it does not make any huge difference, let's get it into 4.9.1 then, the =
less changes we made to pre-release tarballs the better (If you agree pleas=
e mark this as submitted so it disappears from the release-team queue and c=
ommit it after we release on wednesday)
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105744/#review16669
-----------------------------------------------------------
On July 27, 2012, 9:54 a.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105744/
> -----------------------------------------------------------
> =
> (Updated July 27, 2012, 9:54 a.m.)
> =
> =
> Review request for Nepomuk, Release Team and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> The old icons will eventually be merged when I make the data migration
> application for Nepomuk.
> =
> This needs to go both in kdelibs and nepomuk-core.
> =
> =
> Diffs
> -----
> =
> nepomuk/core/resource.cpp eba3cea =
> =
> Diff: http://git.reviewboard.kde.org/r/105744/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105744/">http://git.reviewboard.kde.org/r/105744/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 30th, 2012, 6:07 p.m., <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What's the outcome for 4.9.0 if we do not get this in?</pre> \
</blockquote>
<p>On July 30th, 2012, 6:10 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing drastic. \
Internal database stuff. Makes very little difference if it goes into 4.9 or 4.9.1 or \
4.10.
Nothing user visible. I currently handle both cases in the user interface.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it does not make any \
huge difference, let's get it into 4.9.1 then, the less changes we made to \
pre-release tarballs the better (If you agree please mark this as submitted so it \
disappears from the release-team queue and commit it after we release on \
wednesday)</pre> <br />
<p>- Albert</p>
<br />
<p>On July 27th, 2012, 9:54 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Release Team and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 27, 2012, 9:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The old icons will eventually be merged when I make the data migration \
application for Nepomuk.
This needs to go both in kdelibs and nepomuk-core.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/core/resource.cpp <span style="color: grey">(eba3cea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105744/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic