[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: Fix crashes due to using the same QUrls in multiple threads.
From: "David Faure" <faure () kde ! org>
Date: 2012-07-25 10:31:00
Message-ID: 20120725103100.23236.47669 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 25, 2012, 9:26 a.m., Sebastian Trueg wrote:
> > Well, this is very unfortuanate. It even makes me think whether we shou=
ld go back to the old version which returned QUrl::fromEncoded in every fun=
ction... I only introduced the global static for performance reasons.
> > Anyway, I am fine with the patch if you add a big comment explaining th=
e problem.
> =
> Vishesh Handa wrote:
> Sebastian, I think you'll have to release a bug fix version of Sopran=
o with this patch.
fromEncoded means parsing -every single time-, so at least this version (pa=
rsing once per thread) is a lot faster already.
Committed with a comment, and a Qt version check so that with Qt5 we automa=
tically go back to a simple global static.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105621/#review16358
-----------------------------------------------------------
On July 25, 2012, 8:58 a.m., David Faure wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105621/
> -----------------------------------------------------------
> =
> (Updated July 25, 2012, 8:58 a.m.)
> =
> =
> Review request for Nepomuk and Release Team.
> =
> =
> Description
> -------
> =
> Fix crashes due to using the same QUrls in multiple threads.
> =
> I'm also working on a Qt4 QUrl fix (using QMutex), and this is already
> fixed in Qt5 (the rewrite does no more delayed parsing), but let's make
> our software stable as soon as possible, too, by using QThreadStorage
> to avoid the race.
> =
> =
> Diffs
> -----
> =
> tools/onto2vocabularyclass.cpp 9a5a92b6210e695a6ad3cba9afe9aa1341759fc5 =
> =
> Diff: http://git.reviewboard.kde.org/r/105621/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> David Faure
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105621/">http://git.reviewboard.kde.org/r/105621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 25th, 2012, 9:26 a.m., <b>Sebastian \
Trueg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Well, this is very unfortuanate. It even makes me think whether we \
should go back to the old version which returned QUrl::fromEncoded in every \
function... I only introduced the global static for performance reasons. Anyway, I am \
fine with the patch if you add a big comment explaining the problem.</pre> \
</blockquote>
<p>On July 25th, 2012, 9:29 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sebastian, I think \
you'll have to release a bug fix version of Soprano with this patch.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fromEncoded means \
parsing -every single time-, so at least this version (parsing once per thread) is a \
lot faster already.
Committed with a comment, and a Qt version check so that with Qt5 we automatically go \
back to a simple global static.</pre> <br />
<p>- David</p>
<br />
<p>On July 25th, 2012, 8:58 a.m., David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Release Team.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 25, 2012, 8:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix crashes due to using the same QUrls in multiple threads.
I'm also working on a Qt4 QUrl fix (using QMutex), and this is already
fixed in Qt5 (the rewrite does no more delayed parsing), but let's make
our software stable as soon as possible, too, by using QThreadStorage
to avoid the race.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/onto2vocabularyclass.cpp <span style="color: \
grey">(9a5a92b6210e695a6ad3cba9afe9aa1341759fc5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105621/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic