'Re: Review Request: refactoring of import wizard to be able to show errors'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request: refactoring of import wizard to be able to show errors
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2012-07-10 20:29:35
Message-ID: 20120710202935.18091.16543 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7003/#review10874
-----------------------------------------------------------

Ship it!

Code looks sane and you got no objection from i18n teams, feel free to commit and if \
you're fast enough it'll be part of RC2

- Albert Astals Cid

On July 2, 2012, 4:55 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7003/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 4:55 p.m.)
> 
> 
> Review request for Release Team.
> 
> 
> Description
> -------
> 
> The appended git patch (uploaded as file) refactors the code import wizard to be \
> able to show import errors. This patch contains i18n string changes.  
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=302671.
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=302671
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://svn.reviewboard.kde.org/r/7003/diff/
> 
> 
> Testing
> -------
> 
> works well in trunk 
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/7003/">http://svn.reviewboard.kde.org/r/7003/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks sane and you \
got no objection from i18n teams, feel free to commit and if you&#39;re fast enough \
it&#39;ll be part of RC2</pre>  <br />

<p>- Albert</p>

<br />
<p>On July 2nd, 2012, 4:55 p.m., Ralf Habacker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Release Team.</div>
<div>By Ralf Habacker.</div>

<p style="color: grey;"><i>Updated July 2, 2012, 4:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The appended git patch (uploaded as file) refactors the code import \
wizard to be able to show import errors. This patch contains i18n string changes. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works well in trunk </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=302671">https://bugs.kde.org/show_bug.cgi?id=302671</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/7003/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 