[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: Improvements to create_tarball so it can properly
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2011-12-18 20:54:46
Message-ID: 20111218205446.19245.51790 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6864/#review10581
-----------------------------------------------------------
That `mkdir #{app}` is actually a bug I did not notice. I just read and tried your \
patch and had no problems with it.
I would say "Ship it", but my ruby knowledge is probably more non-existent than yours \
;)
- Kåre Särs
On Dec. 17, 2011, 5 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6864/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2011, 5 p.m.)
>
>
> Review request for kdelibs, Release Team and Kåre Särs.
>
>
> Description
> -------
>
> kio_gopher is a kioslave, thus it's docs are not in \
> docs/extragear-network/kio_gopher but in docs/extragear-network/kioslave/gopher/
> I addded a few special casing for when an addDocs entry contains a / since you need \
> recursive mkdir and some special casing in the copy.
> I could probably fold the old code with the new one, but did not want to break \
> anything and since i ruby knowledge is totally non existent i decided to go the \
> safe way.
> Kare, i'm also adding you because i'm removing a
> `mkdir #{app}`
> you added that i don't see why it's needed, it was basically creating an empty dir \
> in my src dir.
>
> Diffs
> -----
>
> home/kde/trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1268943
>
> Diff: http://svn.reviewboard.kde.org/r/6864/diff/diff
>
>
> Testing
> -------
>
> I now can build kio_gopher with the following config
>
> [kio-gopher]
> gitModule = yes
> mainmodule = extragear
> submodule = network
> kde_release = no
> docs = yes
> addDocs = kioslave/gopher
> translations = yes
> version = 0.1.4
> custompo = kio_gopher
>
>
> Thanks,
>
> Albert Astals Cid
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6864/">http://svn.reviewboard.kde.org/r/6864/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That `mkdir #{app}` is \
actually a bug I did not notice. I just read and tried your patch and had no problems \
with it.
I would say "Ship it", but my ruby knowledge is probably more non-existent \
than yours ;)</pre> <br />
<p>- Kåre</p>
<br />
<p>On December 17th, 2011, 5 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Release Team and Kåre Särs.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2011, 5 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kio_gopher is a kioslave, thus it's docs are not in \
docs/extragear-network/kio_gopher but in docs/extragear-network/kioslave/gopher/
I addded a few special casing for when an addDocs entry contains a / since you need \
recursive mkdir and some special casing in the copy.
I could probably fold the old code with the new one, but did not want to break \
anything and since i ruby knowledge is totally non existent i decided to go the safe \
way.
Kare, i'm also adding you because i'm removing a
`mkdir #{app}`
you added that i don't see why it's needed, it was basically creating an \
empty dir in my src dir.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I now can build kio_gopher with the following config
[kio-gopher]
gitModule = yes
mainmodule = extragear
submodule = network
kde_release = no
docs = yes
addDocs = kioslave/gopher
translations = yes
version = 0.1.4
custompo = kio_gopher
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>home/kde/trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb <span \
style="color: grey">(1268943)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6864/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic