[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 113198: Execute autostart migrations using a MigrationExecutor that can sus
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2013-10-11 10:07:49
Message-ID: 20131011100749.27686.11561 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113198/
-----------------------------------------------------------

Review request for KDEPIM.


Repository: kdepim-runtime


Description
-------

This patch wraps the execution of all autostart migrators with a MigrationExecutor \
(which is a KJob). The MigrationExecutor is responsible for controlling the execution \
of its migrators, and exposes control for suspension to the user via \
KUiServerJobTracker. This should result in the same UI as used for copy jobs by KIO.


Diffs
-----

  agents/migration/CMakeLists.txt 06ac3328194960563c7f91b89131e9667a0c24fd 
  agents/migration/migrationagent.cpp eea66c517cd6c99efe8280adf17fe7d0f9dae6d3 
  agents/migration/migrationexecutor.h PRE-CREATION 
  agents/migration/migrationexecutor.cpp PRE-CREATION 
  agents/migration/migrationscheduler.h 3e0afb2266dece8da58c0f74191b1c1914c40ef3 
  agents/migration/migrationscheduler.cpp 6fbb7bd9dbcaad34563ff73490dd281174d6866b 
  agents/migration/tests/CMakeLists.txt 69663ee9bfa53a83a30055612a25ac7a377050ab 
  agents/migration/tests/dummymigrator.h PRE-CREATION 
  agents/migration/tests/dummymigrator.cpp PRE-CREATION 
  agents/migration/tests/schedulertest.cpp 2b5518329f8396bfef0f2e204c8d87420debb9c6 
  migration/migratorbase.h 47811230d41d501b16c460ec8cd45f1acf6efa4a 
  migration/migratorbase.cpp 582cf55364aee33a7c301a120d875d2c5a99e3a2 

Diff: http://git.reviewboard.kde.org/r/113198/diff/


Testing
-------

I tested it using KWidgetJobTracker (because I couldn't get a notification plasmoid \
to work in my devel session), and extended the unit-tests accordingly.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]