[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: Fix for Bug 207779 - Kmail removes
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2011-01-05 17:58:55
Message-ID: 20110105175855.19949.47289 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100281/#review743
-----------------------------------------------------------


It would also nice if you write a unit test for this behavior, in kdelibs. Shouldn't \
be too hard since you can simply add it to the existing test file.

- Thomas


On 2011-01-03 20:23:44, Frank Vanderham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100281/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 20:23:44)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The KMail message editor uses Qt's rich text editor functionality. The HTML markup \
> generated by this control is not compatible with email readers such as MS Outlook. \
> This fix intercepts the HTML markup generated by the editor and fixes the markup \
> before sending it out. Contrary to the previous approach, I now use good ol' \
> regular expressions instead of the QWebKit to parse and change the HTML markup, in \
> order to remove the QWebKit dependency. This should make the fix applicable to \
> WinCE and also backwards compatible to 4.4 (which I hope happens, since that is my \
> purpose here). 
> [Personal note: I need to stress that as end-user of KDE for business purposes \
> myself, this is a huge problem with KMail today: my customers complain my KMail \
> generated email looks terrible when received, which is what prompted me to roll up \
> my sleeves and fix it myself.] 
> 
> This addresses bug 207779.
> http://bugs.kde.org/show_bug.cgi?id=207779
> 
> 
> Diffs
> -----
> 
> messagecomposer/CMakeLists.txt ae2c106 
> messagecomposer/kmeditor.cpp 86bae8a 
> 
> Diff: http://git.reviewboard.kde.org/r/100281/diff
> 
> 
> Testing
> -------
> 
> I stood up a MS system with Outlook Express and send through a number of HTML \
> formatted emails, especially with "empty lines", bullet lists and numbered lists \
> (which all show up mangled prior to the fix). All those emails arrived as desired. 
> After Torgny's comment, I also added a test case for Thunderbird: email arrived as \
> desired. Of course, the mail viewed in KMail also looks as required. 
> 
> Thanks,
> 
> Frank
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]