[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10697: Make the badge text readable on dark color schemes
From:       Milian Wolff <noreply () phabricator ! kde ! org>
Date:       2018-02-20 20:24:07
Message-ID: 20180220202407.1.FE264410A79E8600 () phabricator ! kde ! org
[Download RAW message or body]

mwolff created this revision.
mwolff added reviewers: broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  The background color should not be used for the foreground text
  color, I believe. The background color is set to theme.highlightColor,
  so use theme.highlightedTextColor for the foreground. This ensures
  the text is readable on a dark color scheme.

TEST PLAN
  unreadable text before, readable now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10697

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Badge.qml

To: mwolff, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">mwolff created this revision.<br />mwolff added reviewers: \
broulik, hein.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel.<br />mwolff requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10697" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
background color should not be used for the foreground text<br /> color, I believe. \
The background color is set to theme.highlightColor,<br /> so use \
theme.highlightedTextColor for the foreground. This ensures<br /> the text is \
readable on a dark color scheme.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>unreadable text before, readable now</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10697" \
rel="noreferrer">https://phabricator.kde.org/D10697</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/taskmanager/package/contents/ui/Badge.qml</div></div></div><br \
/><div><strong>To: </strong>mwolff, broulik, hein<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]