[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7089: [Breeze Style] Fix flickering during KPageTreeView animation
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2017-08-03 12:39:37
Message-ID: 20170803123918.98628.C69DFE8D23AD547C () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:407
> +                pal.setColor( QPalette::Active, QPalette::Base, \
> scrollArea->palette().color( scrollArea->backgroundRole() ) ); +                \
> scrollArea->setPalette(pal); }

Setting palettes manually is always somewhat dangerous, (can break child widgets for \
instance, which would inherit this palette).  Can we at least hide this code behind a \
check for QTreeView, and even "isAnimated()" ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7089

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7089" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7089#inline-28953" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">breezestyle.cpp:407</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span \
class="n">pal</span><span class="p">.</span><span class="n">setColor</span><span \
class="p">(</span> <span class="n">QPalette</span><span style="color: \
#aa2211">::</span><span class="n">Active</span><span class="p">,</span> <span \
class="n">QPalette</span><span style="color: #aa2211">::</span><span \
class="n">Base</span><span class="p">,</span> <span class="n">scrollArea</span><span \
style="color: #aa2211">-&gt;</span><span class="n">palette</span><span \
class="p">().</span><span class="n">color</span><span class="p">(</span> <span \
class="n">scrollArea</span><span style="color: #aa2211">-&gt;</span><span \
class="n">backgroundRole</span><span class="p">()</span> <span class="p">)</span> \
<span class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">                <span \
class="n">scrollArea</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setPalette</span><span class="p">(</span><span class="n">pal</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; ">            \
<span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Setting palettes manually is always somewhat dangerous, (can break child \
widgets for instance, which would inherit this palette). <br /> Can we at least hide \
this code behind a check for QTreeView, and even &quot;isAnimated()&quot; \
?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7089" \
rel="noreferrer">https://phabricator.kde.org/D7089</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hpereiradacosta<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]