'Re: Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2016-11-17 11:37:18
Message-ID: 20161117113718.24472.48693 () mimi ! kde ! org
[Download RAW message or body]

--===============2339110736884379990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128526/
-----------------------------------------------------------

(Updated Nov. 17, 2016, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Andreas Kainz.


Changes
-------

Submitted with commit 2d8b2ec7b1c96ffc232db6dcd919e449a6c8b063 by Jaroslaw Staniek to \
branch master.


Repository: breeze-icons


Description
-------

Make BINARY_ICONS_RESOURCE ON by default. Otherwise packagers will not create \
packages with breeze-icons.rcc. Let them possible create split packages - 1 with icon \
files and 1 with the rcc file.

Also our Jenkins fails to create the file, apps have no way to add dependency on \
breeze-icons "with rcc", there's just breeze-icons that we can depend on. Example \
failure: https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console



Diffs
-----

  CMakeLists.txt c0623ca 

Diff: https://git.reviewboard.kde.org/r/128526/diff/


Testing
-------

breeze-icons now installs the .rcc file.


Thanks,

Jarosław Staniek


--===============2339110736884379990==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128526/">https://git.reviewboard.kde.org/r/128526/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Andreas Kainz.</div>
<div>By Jarosław Staniek.</div>


<p style="color: grey;"><i>Updated Nov. 17, 2016, 11:37 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2d8b2ec7b1c96ffc232db6dcd919e449a6c8b063 by \
Jaroslaw Staniek to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Make BINARY_ICONS_RESOURCE ON by default. Otherwise \
packagers will not create packages with breeze-icons.rcc. Let them possible create \
split packages - 1 with icon files and 1 with the rcc file.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
our Jenkins fails to create the file, apps have no way to add dependency on \
breeze-icons "with rcc", there's just breeze-icons that we can depend on. Example \
failure: https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">breeze-icons now installs the .rcc file.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c0623ca)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128526/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2339110736884379990==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic