[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125187: Stop requiring Frameworks 5.15
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2015-09-15 9:59:03
Message-ID: 20150915095903.2235.5503 () mimi ! kde ! org
[Download RAW message or body]
--===============7304496560451598193==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.
>
> David Faure wrote:
> As you want. You're raising the bar for new contributors, who can't work on your \
> code using the latest KDE Frameworks release.
> You and me might compile everything, but you'll get more contributors if you let \
> people work on workspace and apps using a released frameworks (for which there are \
> distro packages) than if you require them to compile frameworks first. Just like we \
> don't require Qt from git, we shouldn't require KF5 from git, I thought this was \
> the general agreement.
> If you're worried about the ifdef, just use the two liner version of the code \
> forever, I was always a bit dubious about adding a method just for that anyway.
> Martin Gräßlin wrote:
> It's really not that uncommon to depend on latest frameworks in workspace. It's \
> common that I add things in KWindowSystem to make use of it in KWin directly. Or \
> lately I used lots of new functionalty from KGlobalAccel directly.
> Yes it raises the entry level, but it's also rather unlikely that we are able to a \
> policy forbidding depending on frameworks master without CI checks.
> Sebastian Kügler wrote:
> Besides, these occasional devs can use the stable branch en then forward port?
>
> Marco Martin wrote:
> -2 from here as well for the same reasons
>
> Ben Cooksley wrote:
> Please note that the CI system is shifting towards only allowing usage of released \
> products. We'll also be imposing a dependency prohibition between Applications and \
> Plasma so there will no longer be any ability to have dependencies between the two. \
> Aleix Pol Gonzalez wrote:
> @Ben: Really? Why? Where was this discussed?
>
> Martin Gräßlin wrote:
> @Ben: where should libraries like kwayland and kdecoration go then? They do not fit \
> requirements of frameworks but might be useable to applications (kwayland is a must \
> have library for any wayland integration).
That has yet to be resolved. Likely another layer which will be released as needed by \
Applications / Plasma which sits in between Frameworks and them will be added I \
suspect. No binary compatibility commitments, same licensing rules as Applications / \
Plasma, just a logically separate product so it doesn't cause dependency problems. I \
don't expect too many libraries or runtime components to end up there (Dr Konqi might \
perhaps?).
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
-----------------------------------------------------------
On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2015, 9:38 a.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing \
> plasma-workspace git master to depend on yet unreleased version of KDE Frameworks \
> to build. David Faure has suggested to use fix like this one until at least \
> Frameworks 5.15 have been released.
> I don't have commit access, so someone needs to commit this for me.
>
>
> Diffs
> -----
>
> applets/icon/plugin/icon_p.cpp 97af67a
>
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
>
>
> Testing
> -------
>
> It builds.
>
>
> Thanks,
>
> Armin K.
>
>
--===============7304496560451598193==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125187/">https://git.reviewboard.kde.org/r/125187/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 14th, 2015, 8:44 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-2, a change for a month in the devel branch doesn't \
make much sense.</p></pre> </blockquote>
<p>On September 14th, 2015, 9:30 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
you want. You're raising the bar for new contributors, who can't work on your code \
using the latest KDE Frameworks release.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You and me might \
compile everything, but you'll get more contributors if you let people work on \
workspace and apps using a released frameworks (for which there are distro packages) \
than if you require them to compile frameworks first. Just like we don't require Qt \
from git, we shouldn't require KF5 from git, I thought this was the general \
agreement.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you're worried about the ifdef, just use the two \
liner version of the code forever, I was always a bit dubious about adding a method \
just for that anyway.</p></pre> </blockquote>
<p>On September 14th, 2015, 9:56 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
really not that uncommon to depend on latest frameworks in workspace. It's common \
that I add things in KWindowSystem to make use of it in KWin directly. Or lately I \
used lots of new functionalty from KGlobalAccel directly.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
it raises the entry level, but it's also rather unlikely that we are able to a policy \
forbidding depending on frameworks master without CI checks.</p></pre> </blockquote>
<p>On September 14th, 2015, 11:44 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Besides, these occasional devs can use the stable branch en then forward \
port?</p></pre> </blockquote>
<p>On September 14th, 2015, 12:03 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-2 \
from here as well for the same reasons</p></pre> </blockquote>
<p>On September 15th, 2015, 8:38 a.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please note that the CI system is shifting towards only allowing usage of \
released products. We'll also be imposing a dependency prohibition between \
Applications and Plasma so there will no longer be any ability to have dependencies \
between the two.</p></pre> </blockquote>
<p>On September 15th, 2015, 8:41 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Ben: \
Really? Why? Where was this discussed?</p></pre> </blockquote>
<p>On September 15th, 2015, 9:08 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Ben: \
where should libraries like kwayland and kdecoration go then? They do not fit \
requirements of frameworks but might be useable to applications (kwayland is a must \
have library for any wayland integration).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
has yet to be resolved. Likely another layer which will be released as needed by \
Applications / Plasma which sits in between Frameworks and them will be added I \
suspect. No binary compatibility commitments, same licensing rules as Applications / \
Plasma, just a logically separate product so it doesn't cause dependency problems. I \
don't expect too many libraries or runtime components to end up there (Dr Konqi might \
perhaps?).</p></pre> <br />
<p>- Ben</p>
<br />
<p>On September 12th, 2015, 9:38 a.m. UTC, Armin K. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Faure.</div>
<div>By Armin K..</div>
<p style="color: grey;"><i>Updated Sept. 12, 2015, 9:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KDesktopFile.readMimeTypes(); hasn't made it into \
Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased \
version of KDE Frameworks to build. David Faure has suggested to use fix like this \
one until at least Frameworks 5.15 have been released.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't have commit access, so someone needs to commit this for me.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icon/plugin/icon_p.cpp <span style="color: grey">(97af67a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125187/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7304496560451598193==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic