[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122781: Enable high DPI pixmaps in systemsettings
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2015-03-03 7:26:37
Message-ID: 20150303072637.6756.13512 () probe ! kde ! org
[Download RAW message or body]
--===============6326875012584190078==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122781/#review76938
-----------------------------------------------------------
Coding all looks fine from my perspective.
I don't have a Plasma 5 environment though - so can't comment on how well this works.
- Ben Cooksley
On March 2, 2015, 6:51 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122781/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 6:51 p.m.)
>
>
> Review request for Plasma and Ben Cooksley.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> Enable high DPI pixmaps in systemsettings
>
>
> Diffs
> -----
>
> app/main.cpp 150ca90
>
> Diff: https://git.reviewboard.kde.org/r/122781/diff/
>
>
> Testing
> -------
>
> Went through every KCM in systemsettings with QT_DEVICE_PIXEL_RATIO=2,including \
> tree view and checked that nothing was broken.
>
> A few things are still low res pixmaps scaled up, but without this everything is \
> low res pixmaps scaled up, so it's no worse. Full list of TODO tasks at \
> https://todo.kde.org/?controller=task&action=show&task_id=981.
>
> Thanks,
>
> David Edmundson
>
>
--===============6326875012584190078==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122781/">https://git.reviewboard.kde.org/r/122781/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Coding all looks fine from my perspective. I don't have a Plasma 5 \
environment though - so can't comment on how well this works.</p></pre> <br />
<p>- Ben Cooksley</p>
<br />
<p>On March 2nd, 2015, 6:51 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Ben Cooksley.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 6:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Enable high DPI pixmaps in systemsettings</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Went through every KCM in systemsettings with \
QT_DEVICE_PIXEL_RATIO=2,including tree view and checked that nothing was broken.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A few things are still low res pixmaps scaled up, but \
without this everything is low res pixmaps scaled up, so it's no worse. Full list of \
TODO tasks at https://todo.kde.org/?controller=task&action=show&task_id=981.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/main.cpp <span style="color: grey">(150ca90)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122781/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6326875012584190078==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic