[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120970: Remove combo "Graphical Effects"
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2014-11-04 12:02:46
Message-ID: 20141104120246.9635.23306 () probe ! kde ! org
[Download RAW message or body]
--===============6192120671751834469==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Lis. 4, 2014, 11:59 dop., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement \
> > QStyle::styleHint(SH_Widget_Animate)? Is it now up to the style then, ie. \
> > animations turned on/off in Oxygen/Breeze?
>
> David Edmundson wrote:
> Turns out that was a very good question.
>
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
>
> So we were using this config entry, but writing it as an integer and reading it as \
> a boolean. So it was animated for everything, except: "Low display resolution and \
> Low CPU"
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at all the \
> animation setting should get derived from the hardware. If a style wants to expose \
> an option that's fine, but it should be in the style specific config..
> Kai Uwe Broulik wrote:
> Deduced from the hardware (and "is remote session") is certainly nice but \
> difficult, no? Also, what about Plasma's animations? We do use \
> units.{long,short}Duration everywhere but can this be disabled somewhere or what \
> settings does that follow?
> Martin Klapetek wrote:
> > We do use units.{long,short}Duration everywhere but can this be disabled \
> > somewhere or what settings does that follow?
>
> Look&Feel package, iirc.
Not only that, you can also enable/disable the individual effects using \
QApplication::setEffectEnabled(Qt::UIEffect effect, bool enable = true), see \
http://qt-project.org/doc/qt-5/qt.html#UIEffect-enum
- Lukáš
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
-----------------------------------------------------------
On Lis. 4, 2014, 11:55 dop., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
>
> (Updated Lis. 4, 2014, 11:55 dop.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Remove combo "Graphical Effects"
>
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
>
>
> Diffs
> -----
>
> kcms/style/finetuning.ui 3abb692
> kcms/style/kcmstyle.cpp 6585ee6
>
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============6192120671751834469==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120970/">https://git.reviewboard.kde.org/r/120970/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On listopad 4th, 2014, 11:59 dop. CET, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Who's responsible for setting the dedicated \
replacement QStyle::styleHint(SH_Widget_Animate)? Is it now up to the style then, ie. \
animations turned on/off in Oxygen/Breeze?</p></pre> </blockquote>
<p>On listopad 4th, 2014, 12:12 odp. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Turns \
out that was a very good question.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: \
inherit;">frameworkintegration/src/kstyle/kstyle.cpp case SH_Widget_Animate: {
KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
return g.readEntry("GraphicEffectsLevel", true);
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So we were using this config entry, but writing it as \
an integer and reading it as a boolean. So it was animated for everything, except: \
"Low display resolution and Low CPU"</p></pre> </blockquote>
<p>On listopad 4th, 2014, 12:20 odp. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Personal opinion: this shouldn't be on any config option at all. If at all \
the animation setting should get derived from the hardware. If a style wants to \
expose an option that's fine, but it should be in the style specific \
config..</p></pre> </blockquote>
<p>On listopad 4th, 2014, 12:51 odp. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Deduced from the hardware (and "is remote session") is certainly nice but \
difficult, no? Also, what about Plasma's animations? We do use \
units.{long,short}Duration everywhere but can this be disabled somewhere or what \
settings does that follow?</p></pre> </blockquote>
<p>On listopad 4th, 2014, 12:56 odp. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">We do use units.{long,short}Duration everywhere but can this be disabled \
somewhere or what settings does that follow?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Look&Feel package, iirc.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
only that, you can also enable/disable the individual effects using \
QApplication::setEffectEnabled(Qt::UIEffect effect, bool enable = true), see \
http://qt-project.org/doc/qt-5/qt.html#UIEffect-enum</p></pre> <br />
<p>- Lukáš</p>
<br />
<p>On listopad 4th, 2014, 11:55 dop. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Lis. 4, 2014, 11:55 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove combo "Graphical Effects"</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It set a config value which was exposed in \
KGlobalSettings::graphicEffectsLevel that is now deprecated.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/style/finetuning.ui <span style="color: grey">(3abb692)</span></li>
<li>kcms/style/kcmstyle.cpp <span style="color: grey">(6585ee6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6192120671751834469==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic