'Re: Review Request 120584: Don't position the panel until it's about to be displayed'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120584: Don't position the panel until it's about to be displayed
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-10-14 17:05:47
Message-ID: 20141014170547.21224.81516 () probe ! kde ! org
[Download RAW message or body]

--===============6901402104667650690==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Ott. 14, 2014, 4:36 p.m., Marco Martin wrote:
> > Sounds sensible.
> > however, can someone try plasma without this patch and with the Qt patch:
> > https://codereview.qt-project.org/#/c/97050/ 
> > 
> > this one may be a workaround for the qt xcb problem adressed in the above, but \
> > i'm not 100% sure since i can't reproduce the issue of panel starting up on wrong \
> > monitor (even if is a workaround, this one may be needed anyways since it would \
> > take aeons anyways for the qt patch making to releases)

even without the patch in qt, to see if it was *that* issue, it can be checked if \
seeting the panels as window can cover (or anything *without* struts) makes the \
problem not happen.

so the problem is the following:
* the panel sets an extended strut, removing its geometry from \
                QScreen::AvailableGeometry()
* if the panel is ill-positioned just a little and overflows in the second screen \
even just a pixel (admittedly a bug in itself, but unrelated), qt xcb sees that the \
panel is not in the availableGeometry() of its screen, so checks if it is of any \
other screen, and if it is of even 1 pixel, it migrates the panel t the new screen

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120584/#review68403
-----------------------------------------------------------

On Ott. 14, 2014, 4:15 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120584/
> -----------------------------------------------------------
> 
> (Updated Ott. 14, 2014, 4:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I was getting the Panels wrongly positioned because Qt would reset the position at \
> some point while initializing the class. This patch disables any position while the \
> panel is not shown and makes sure it's placed when it's set to be shown. 
> 
> Diffs
> -----
> 
> shell/panelview.cpp 9260c18 
> 
> Diff: https://git.reviewboard.kde.org/r/120584/diff/
> 
> 
> Testing
> -------
> 
> Both my installations initialize properly now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============6901402104667650690==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120584/">https://git.reviewboard.kde.org/r/120584/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On ottobre 14th, 2014, 4:36 p.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sounds sensible. however, can someone try plasma \
without this patch and with the Qt patch: \
https://codereview.qt-project.org/#/c/97050/ </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
one may be a workaround for the qt xcb problem adressed in the above, but i'm not \
100% sure since i can't reproduce the issue of panel starting up on wrong monitor \
(even if is a workaround, this one may be needed anyways since it would take aeons \
anyways for the qt patch making to releases)</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">even \
without the patch in qt, to see if it was <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">that</em> issue, it can \
be checked if seeting the panels as window can cover (or anything <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">without</em> struts) makes the problem not happen.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so \
the problem is the following: <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> the panel sets an extended strut, \
removing its geometry from QScreen::AvailableGeometry() </em> if the panel is \
ill-positioned just a little and overflows in the second screen even just a pixel \
(admittedly a bug in itself, but unrelated), qt xcb sees that the panel is not in the \
availableGeometry() of its screen, so checks if it is of any other screen, and if it \
is of even 1 pixel, it migrates the panel t the new screen</p></pre> <br />

<p>- Marco</p>

<br />
<p>On ottobre 14th, 2014, 4:15 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Ott. 14, 2014, 4:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I was getting the Panels wrongly positioned because Qt \
would reset the position at some point while initializing the class. This patch \
disables any position while the panel is not shown and makes sure it's placed when \
it's set to be shown.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Both my installations initialize properly \
now.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/panelview.cpp <span style="color: grey">(9260c18)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120584/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6901402104667650690==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 