From kde-panel-devel Tue Oct 14 13:46:36 2014 From: "Aleix Pol Gonzalez" Date: Tue, 14 Oct 2014 13:46:36 +0000 To: kde-panel-devel Subject: Re: Review Request 120581: Don't crash if the plasmoid wasn't properly loaded Message-Id: <20141014134636.21223.9159 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141329443622807 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3992829693786439235==" --===============3992829693786439235== Content-Type: multipart/alternative; boundary="===============5084411377336571937==" --===============5084411377336571937== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120581/ ----------------------------------------------------------- (Updated Oct. 14, 2014, 1:46 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null. This makes Plasma crash when a plasmoid is loaded. Diffs ----- src/plasmaquick/appletquickitem.cpp 45055a5 Diff: https://git.reviewboard.kde.org/r/120581/diff/ Testing ------- Doesn't crash anymore. Thanks, Aleix Pol Gonzalez --===============5084411377336571937== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120581/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

By Aleix Pol Gonzalez.

Updated Oct. 14, 2014, 1:46 p.m.

Repository: plasma-framework

Description

If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.
This makes Plasma crash when a plasmoid is loaded.

Testing

Doesn't crash anymore.

Diffs

src/plasmaquick/appletquickitem.cpp (45055a5)

View Diff

--===============5084411377336571937==-- --===============3992829693786439235== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3992829693786439235==--