[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119515: Support per-activity favourites
From: "Eike Hein" <hein () kde ! org>
Date: 2014-07-28 12:58:02
Message-ID: 20140728125802.15443.77293 () probe ! kde ! org
[Download RAW message or body]
--===============0787208759062845478==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 28, 2014, 12:03 p.m., Marco Martin wrote:
> > +1 from me, would like toknow from Eike if this provides all is needed for use \
> > cases outside kickoff
Kicker doesn't use Kickoff's models, i.e. activity support has to be implemented in \
Kicker's own favorites model.
- Eike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63321
-----------------------------------------------------------
On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 11:49 a.m.)
>
>
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This patch adds the support to have favourites linked to activities.
>
> It uses org.kde.activities.ResourceModel to show favorites.
>
> It supports:
> - adding a favourite to all activities (the previous behaviour)
> - adding a favourite to the current activity
> - moving a favourite between 'all activities' and 'current activity' modes (it does \
> not affect non-current activities)
> - drag-and-drop reordering of items (like the previous one)
> - sorting A-Z, Z-A (like the previous one)
> - transitions previously defined favourites to the new system*
>
> Context menu item captions could maybe use some improvement.
>
> Screenshot available at: \
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
>
> * this can also be used for defining the default favourites in a global kickoffrc \
> file - instead of them being hard-coded like they currently are.
>
> Diffs
> -----
>
> applets/kickoff/CMakeLists.txt 28e7029
> applets/kickoff/core/favoritesmodel.h 27a0626
> applets/kickoff/core/favoritesmodel.cpp f05588b
> applets/kickoff/core/kickoffplugin.cpp f549981
> applets/kickoff/core/krunnermodel.h 3916829
> applets/kickoff/core/krunnermodel.cpp db2adab
> applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874
> applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4
> applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c
>
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Ivan Čukić
>
>
--===============0787208759062845478==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119515/">https://git.reviewboard.kde.org/r/119515/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2014, 12:03 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1 from me, would like toknow from Eike if this \
provides all is needed for use cases outside kickoff</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Kicker doesn't use Kickoff's models, i.e. activity support has to be \
implemented in Kicker's own favorites model.</p></pre> <br />
<p>- Eike</p>
<br />
<p>On July 28th, 2014, 11:49 a.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated July 28, 2014, 11:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds the support to have favourites linked \
to activities.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It uses \
org.kde.activities.ResourceModel to show favorites.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
supports:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
- adding a favourite to all activities (the previous behaviour)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- adding a favourite to the current activity<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
- moving a favourite between 'all activities' and 'current activity' modes (it does \
not affect non-current activities)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
- drag-and-drop reordering of items (like the previous one)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- sorting A-Z, Z-A (like the previous one)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
- transitions previously defined favourites to the new system*</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Context menu item captions could maybe use some \
improvement.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Screenshot available at: \
http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">this can also be used for defining the \
default favourites in a global kickoffrc file - instead of them being hard-coded like \
they currently are.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/CMakeLists.txt <span style="color: grey">(28e7029)</span></li>
<li>applets/kickoff/core/favoritesmodel.h <span style="color: \
grey">(27a0626)</span></li>
<li>applets/kickoff/core/favoritesmodel.cpp <span style="color: \
grey">(f05588b)</span></li>
<li>applets/kickoff/core/kickoffplugin.cpp <span style="color: \
grey">(f549981)</span></li>
<li>applets/kickoff/core/krunnermodel.h <span style="color: \
grey">(3916829)</span></li>
<li>applets/kickoff/core/krunnermodel.cpp <span style="color: \
grey">(db2adab)</span></li>
<li>applets/kickoff/package/contents/ui/ContextMenu.qml <span style="color: \
grey">(6a67874)</span></li>
<li>applets/kickoff/package/contents/ui/FavoritesView.qml <span style="color: \
grey">(6c2d5d4)</span></li>
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(6291b7c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119515/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0787208759062845478==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic