[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-07-17 4:40:51
Message-ID: 20140717044051.32551.96327 () probe ! kde ! org
[Download RAW message or body]
--===============5347934796599521176==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 16, 2014, 6:54 a.m., Ben Cooksley wrote:
> > As systemsettingsview is unlikely to break BC any further in the 4.x series, \
> > could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine to go \
> > in from my perspective.
>
> Hrvoje Senjan wrote:
> off course, i've just used 5, as the rest of the Workspace 'umbrella' uses it.
>
> Ben Cooksley wrote:
> Any movement on this change Hrvoje? Once the change to SOVERSION 3 is made i'm \
> happy for this to go in - unless there is a compelling reason why it should be 5.
> Hrvoje Senjan wrote:
> i can push as soon as i know which branches to touch. only master makes sense, but \
> want to confirm.
I'm not aware of what the policy is from distributions on bumping SOVERSION in minor \
releases, however as it will probably improve co-installability I suspect including \
this in the release/stable branch would be welcome. I've no objections to it - all \
depends on the policies set by the release-team and distributions.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118387/#review60161
-----------------------------------------------------------
On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118387/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 7:26 p.m.)
>
>
> Review request for Plasma and Ben Cooksley.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version
>
>
> Diffs
> -----
>
> core/CMakeLists.txt 9752ad7
>
> Diff: https://git.reviewboard.kde.org/r/118387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============5347934796599521176==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118387/">https://git.reviewboard.kde.org/r/118387/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 16th, 2014, 6:54 a.m. UTC, <b>Ben \
Cooksley</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As systemsettingsview is unlikely to break BC any further in the 4.x \
series, could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine \
to go in from my perspective.</pre> </blockquote>
<p>On June 16th, 2014, 2:37 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">off course, i've \
just used 5, as the rest of the Workspace 'umbrella' uses it.</pre> \
</blockquote>
<p>On July 16th, 2014, 12:28 p.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
movement on this change Hrvoje? Once the change to SOVERSION 3 is made i'm happy for \
this to go in - unless there is a compelling reason why it should be 5.</p></pre> \
</blockquote>
<p>On July 16th, 2014, 7:33 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i can \
push as soon as i know which branches to touch. only master makes sense, but want to \
confirm.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not aware of what the policy is from distributions on bumping SOVERSION in minor \
releases, however as it will probably improve co-installability I suspect including \
this in the release/stable branch would be welcome. I've no objections to it - all \
depends on the policies set by the release-team and distributions.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On May 28th, 2014, 7:26 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Ben Cooksley.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to \
start 4.x version</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/CMakeLists.txt <span style="color: grey">(9752ad7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118387/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5347934796599521176==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic