--===============1693104110543211245==
Content-Type: multipart/signed; boundary="nextPart4933719.Mtk3Ov3Qyj"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart4933719.Mtk3Ov3Qyj
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hello,

On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote:
> El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va esc=
riure:
> > since it was done earlier this week, better announce it formally, s=
o
> > everybody can actually do the -review part ;)
>=20
> Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken =
as the
> rest of frameworks ;-))

Thanks for looking into it.

I checked with Burkhard L=FCck too and he said it was fine on the doc s=
ide as=20
well.
We just ended a clean up pass with Aur=E9lien to make sure it was compl=
iant with=20
all the active policies, so it's now OK on our side as well.

As far as I'm concerned it's ready to move in frameworks now.

> I'll be fixed once Aurelien does the patch for all frameworks definin=
g the
> cmake variable for the domain.
>=20
> There's one thing that someone needs to think about and is this two s=
trings
> in the qml files
>=20
> QueryDialog.qml:52:    property string acceptButtonText: i18n("Ok")
> QueryDialog.qml:53:    property string rejectButtonText: i18n("Cancel=
")
>=20
> That either need to load the catalog manually (the cmake define won't=
 help
> here) or they need to specify the domain or they need to be killed an=
d use
> som kguistdthing that provides those translations.

OK, thanks.

Cheers.
=2D-=20
K=E9vin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com


--nextPart4933719.Mtk3Ov3Qyj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlNa/soACgkQB0u7y43syeLRqwCfVpR4z9tDoF+fkgaXebolZQ0h
BLEAniRcj/v/HoMQ/P2kO4Wk6vUiLkUb
=8KZd
-----END PGP SIGNATURE-----

--nextPart4933719.Mtk3Ov3Qyj--


--===============1693104110543211245==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1693104110543211245==--