[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117644: screenlocker: don't leave behind screensaver processes
From: "Commit Hook" <null () kde ! org>
Date: 2014-04-25 21:04:08
Message-ID: 20140425210408.23578.18202 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117644/#review56571
-----------------------------------------------------------
This review has been submitted with commit b1fa2678d36f6ce215e8d8ec1d57608079f36c89 \
by Wolfgang Bauer to branch master.
- Commit Hook
On April 24, 2014, 10:28 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117644/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 10:28 p.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Bugs: 224200
> http://bugs.kde.org/show_bug.cgi?id=224200
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Currently the screen locker just kills the greeter (kscreenlocker_greet) when the \
> screen is unlocked by the user during the grace time. But apparently this can leave \
> behind running screensaver processes launched by the greeter, see the bug report \
> (which has the highest number of votes of all open bugs AFAICS).
> This patch changes this to only terminate the greeter, and adds a signal handler to \
> the greeter to exit gracefully in this case. The signal handler exits with return \
> code 1, so that it is not possible to circumvent the password input by just sending \
> a SIGTERM. (the screen locker restarts the greeter in case it doesn't quit with \
> exit code 0)
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/main.cpp d898734
> ksmserver/screenlocker/ksldapp.cpp 3dfcc9e
>
> Diff: https://git.reviewboard.kde.org/r/117644/diff/
>
>
> Testing
> -------
>
> Configure a legacy screensaver in Systemsettings->Display and Monitor->Screen \
> Locker, be sure to leave "Require Password after" disabled. Wait for the screen \
> locker to kick in. Unlock the screen by moving the mouse or pressing a key.
> Check the process list.
>
> Without this patch at least kswarm.kss and kblankscreen.kss reliably kept running \
> after unlocking the screen on my system. With this patch they quit themselves.
>
> I'm using this patch for over two weeks now, and I haven't seen any left-over \
> screen saver processes any more (and I even set the timeout to 1 minute).
> I also tried to terminate kscreenlocker_greet manually by running "killall \
> kscreenlocker_greet" from a text console in case of a password required, and the \
> locker didn't quit, you still have to enter the password.
>
> Thanks,
>
> Wolfgang Bauer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117644/">https://git.reviewboard.kde.org/r/117644/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b1fa2678d36f6ce215e8d8ec1d57608079f36c89 by Wolfgang Bauer to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On April 24th, 2014, 10:28 p.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated April 24, 2014, 10:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=224200">224200</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the screen locker just kills the greeter (kscreenlocker_greet) \
when the screen is unlocked by the user during the grace time. But apparently this \
can leave behind running screensaver processes launched by the greeter, see the bug \
report (which has the highest number of votes of all open bugs AFAICS).
This patch changes this to only terminate the greeter, and adds a signal handler to \
the greeter to exit gracefully in this case. The signal handler exits with return \
code 1, so that it is not possible to circumvent the password input by just sending a \
SIGTERM. (the screen locker restarts the greeter in case it doesn't quit with \
exit code 0)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configure a legacy screensaver in Systemsettings->Display and \
Monitor->Screen Locker, be sure to leave "Require Password after" \
disabled. Wait for the screen locker to kick in.
Unlock the screen by moving the mouse or pressing a key.
Check the process list.
Without this patch at least kswarm.kss and kblankscreen.kss reliably kept running \
after unlocking the screen on my system. With this patch they quit themselves.
I'm using this patch for over two weeks now, and I haven't seen any left-over \
screen saver processes any more (and I even set the timeout to 1 minute).
I also tried to terminate kscreenlocker_greet manually by running "killall \
kscreenlocker_greet" from a text console in case of a password required, and the \
locker didn't quit, you still have to enter the password.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(d898734)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(3dfcc9e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117644/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic