'Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-04-25 17:24:01
Message-ID: 20140425172401.23578.19685 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/
-----------------------------------------------------------

(Updated April 25, 2014, 5:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

[kglobalaccel] Remove Component::showKCM

Component::showKCM was a method exported to DBus to wrap the invocation
of "kcmshell5 keys".

According to lxr there is no application using this DBus method and it's
not much use anyway as it doesn't open the keys KCM for the component.

This removes the KIOWidgets dependency from kglobalaccel.

Diffs
-----

  kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
  kglobalaccel/component.h 019c315374ecd226cb0820519a76bdbc3ced678c 
  kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 

Diff: https://git.reviewboard.kde.org/r/117455/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117455/">https://git.reviewboard.kde.org/r/117455/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 25, 2014, 5:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[kglobalaccel] Remove Component::showKCM

Component::showKCM was a method exported to DBus to wrap the invocation
of &quot;kcmshell5 keys&quot;.

According to lxr there is no application using this DBus method and it&#39;s
not much use anyway as it doesn&#39;t open the keys KCM for the component.

This removes the KIOWidgets dependency from kglobalaccel.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kglobalaccel/CMakeLists.txt <span style="color: \
grey">(b77f85edab091fd260fb9bddb1ddb43df445c5fe)</span></li>

 <li>kglobalaccel/component.h <span style="color: \
grey">(019c315374ecd226cb0820519a76bdbc3ced678c)</span></li>

 <li>kglobalaccel/component.cpp <span style="color: \
grey">(72a4980a3c26140bde692d376338da03dc67086e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117455/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 