'Re: Review Request 117563: React to containment status changes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117563: React to containment status changes
From:       "Commit Hook" <null () kde ! org>
Date:       2014-04-15 14:03:25
Message-ID: 20140415140325.31494.38772 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117563/#review55815
-----------------------------------------------------------

This review has been submitted with commit dae9b75fe2a237635cbe921cb9e0e42357b3e1e7 \
by Aleix Pol to branch master.

- Commit Hook

On April 15, 2014, 12:16 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117563/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 12:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> At the moment the Panel didn't have any code to react status changes from the \
> containment (and therefore its applets). 
> This patch aims to add this, only problem being that it doesn't work. The "unhide \
> requested" and "unhiding" messages are being displayed though. 
> I've been looking for the code that does the actual display of the auto-hiding \
> panels and I wasn't able to find it, help is welcome. 
> 
> Diffs
> -----
> 
> shell/panelview.h 056a1e4 
> shell/panelview.cpp 53d690a 
> 
> Diff: https://git.reviewboard.kde.org/r/117563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117563/">https://git.reviewboard.kde.org/r/117563/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit dae9b75fe2a237635cbe921cb9e0e42357b3e1e7 by Aleix Pol to branch \
master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On April 15th, 2014, 12:16 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated April 15, 2014, 12:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">At the moment the Panel didn&#39;t have any code to react status changes \
from the containment (and therefore its applets).

This patch aims to add this, only problem being that it doesn&#39;t work. The \
&quot;unhide requested&quot; and &quot;unhiding&quot; messages are being displayed \
though.

I&#39;ve been looking for the code that does the actual display of the auto-hiding \
panels and I wasn&#39;t able to find it, help is welcome.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/panelview.h <span style="color: grey">(056a1e4)</span></li>

 <li>shell/panelview.cpp <span style="color: grey">(53d690a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117563/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 