[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 110716: Get the Plasma Theme Text Color for the Notes applet
From: "Anne-Marie Mahfouf" <annma () kde ! org>
Date: 2013-05-29 18:57:41
Message-ID: 20130529185741.9835.43443 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110716/
-----------------------------------------------------------
Review request for Plasma, Aaron J. Seigo, Davide Bettio, and Sebastian Kügler.
Description
-------
For theme text color, the code was Plasma::Theme::ButtonTextColor instead of \
Plasma::Theme::TextColor in 2 places. When the theme changes, make the text change \
color.
This addresses bug 320342.
http://bugs.kde.org/show_bug.cgi?id=320342
Diffs
-----
applets/notes/notes.cpp 5c2ed70
Diff: http://git.reviewboard.kde.org/r/110716/diff/
Testing
-------
Tested with several themes, Air, ThinAir2 and Oxygen.
Thanks,
Anne-Marie Mahfouf
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110716/">http://git.reviewboard.kde.org/r/110716/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Davide Bettio, and Sebastian \
Kügler.</div> <div>By Anne-Marie Mahfouf.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For theme text color, the code was Plasma::Theme::ButtonTextColor \
instead of Plasma::Theme::TextColor in 2 places. When the theme changes, make the \
text change color.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with several themes, Air, ThinAir2 and Oxygen. </pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320342">320342</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notes/notes.cpp <span style="color: grey">(5c2ed70)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110716/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic