[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma Mediacenter: Inroduce displaying and
From: "Beat Wolf" <asraniel () fryx ! ch>
Date: 2010-09-24 10:32:56
Message-ID: 20100924103256.1503.85250 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4252/#review7749
-----------------------------------------------------------
what is the status of this patch?
- Beat
On 2010-06-08 08:03:13, Christophe Olinger wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4252/
> -----------------------------------------------------------
> =
> (Updated 2010-06-08 08:03:13)
> =
> =
> Review request for Plasma and Alessandro Diaferia.
> =
> =
> Summary
> -------
> =
> This patch introduces a new label in the bottom bar. When playing/looking=
at a media file, it displays its nepomuk tags. When clicking on the label,=
the user can add/edit tags to an item (comma separated). When multiple ite=
ms are selected, tags are applied to all of them.
> =
> P.S. The videostate.cpp contains comments.
> =
> =
> Diffs
> -----
> =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/med=
iacenterstate.h 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/med=
iacenterstate.cpp 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mus=
icstate.h 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mus=
icstate.cpp 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/pic=
turestate.h 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/pic=
turestate.cpp 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/vid=
eostate.h 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/vid=
eostate.cpp 1135839 =
> trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacent=
er/mainwindow.cpp 1135839 =
> =
> Diff: http://svn.reviewboard.kde.org/r/4252/diff
> =
> =
> Testing
> -------
> =
> Adding, editing tags was tested extensively. No more bugs should remain (=
TM)
> =
> =
> Thanks,
> =
> Christophe
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4252/">http://svn.reviewboard.kde.org/r/4252/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is the status of \
this patch?</pre> <br />
<p>- Beat</p>
<br />
<p>On June 8th, 2010, 8:03 a.m., Christophe Olinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Alessandro Diaferia.</div>
<div>By Christophe Olinger.</div>
<p style="color: grey;"><i>Updated 2010-06-08 08:03:13</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch introduces a new label in the bottom bar. When \
playing/looking at a media file, it displays its nepomuk tags. When clicking on the \
label, the user can add/edit tags to an item (comma separated). When multiple items \
are selected, tags are applied to all of them.
P.S. The videostate.cpp contains comments.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding, editing tags was tested extensively. No more bugs should remain \
(TM)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp \
<span style="color: grey">(1135839)</span></li>
<li>trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp \
<span style="color: grey">(1135839)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4252/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic