[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Show shortcut for System Activity in krunner
From:       "John Tapsell" <johnflux () gmail ! com>
Date:       2009-12-01 12:12:30
Message-ID: 20091201121230.15028.62786 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2308/
-----------------------------------------------------------

(Updated 2009-12-01 12:12:29.713593)


Review request for Plasma.


Summary (updated)
-------

This shows the global shortcut in the tooltip for the System Activity button in the \
default krunner interface.

It required rearranging the code slightly in krunnerapp so that the interface is \
created after the shortcuts are created.

NOTE:

This adds the string i18n("%1 (%2)")    but we are currently in string freeze...


Diffs
-----

  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1056420 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1056420 
  trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1056420 

Diff: http://reviewboard.kde.org/r/2308/diff


Testing
-------

Compiled, ran.  Hovered over and saw that the tooltip had changed.  Then went to \
system settings and changed the shortcut, and saw that the tooltip updated instantly.


Thanks,

John

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]