[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Kickoff applet sizing fixes
From:       Sebastian Kuegler <sebas () kde ! org>
Date:       2008-05-15 13:16:26
Message-ID: 20080515131626.10209.76199 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/358/#review333
-----------------------------------------------------------

Ship it!


Looks good to me.


/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
<http://mattr.info:8080/r/358/#comment225>

    This should be contentsRect(), no? Otherwise (when there's a background for this \
applet), geometry() includes the applet's background so the icon gets resized to the \
wrong size (and thus blurred).


- Sebastian


On 2008-05-15 08:00:56, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info:8080/r/358/
> -----------------------------------------------------------
> 
> (Updated 2008-05-15 08:00:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes both kickoff applets to still behave as a forced square in little \
> panel sizes, so space won't get wasted, but not on bigger panels, so it behaves \
> more nice in vertical panels where the k icon doesn't became huge anymore this by \
> setting a square maximum size instead of a square minimum size 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
> /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp
> 
> Diff: http://mattr.info:8080/r/358/diff
> 
> 
> Testing
> -------
> 
> various resizings
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]