'Re: [KDE/Mac] Review Request 125649: [OS X] install icon resources in app bundles where this doesn't'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: [KDE/Mac] Review Request 125649: [OS X] install icon resources in app bundles where this doesn't
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2015-10-15 22:09:54
Message-ID: 20151015220954.1403.41093 () mimi ! kde ! org
[Download RAW message or body]

--===============3383115846523266230==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125649/#review86898
-----------------------------------------------------------

Ship it!

Cannot test but looks good!

How can we ensure it's ported to calligra master (3.0)?
Otherwise we'd loose the fixes.

- Jarosław Staniek

On Oct. 15, 2015, 10:55 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125649/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 10:55 p.m.)
> 
> 
> Review request for Calligra and KDE Software on Mac OS X.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Builds on OS X currently generate icons for most Calligra applications, but those \
> are installed only for a happy few (Krita, Braindump and Kexi). The other \
> applications require an explicit install command of the generated `.icns` file into \
> the app bundle's Resources directory. 
> The attached patch takes care of that.
> 
> In addition, it corrects the picture source directories for calligragemini and \
> calligraauthor so those applications can have icons on other platforms too, and \
> replaces the `Q_WS_MACOS` token with the (IMHO) more appropriate `APPLE` token. 
> 
> Diffs
> -----
> 
> flow/part/CMakeLists.txt 58882f1 
> gemini/CMakeLists.txt 85123fa 
> karbon/CMakeLists.txt b574779 
> plan/CMakeLists.txt ad39f57 
> sheets/CMakeLists.txt b0cc134 
> stage/app/CMakeLists.txt 079bece 
> words/app/CMakeLists.txt 1e73971 
> words/part/CMakeLists.txt 9143176 
> 
> Diff: https://git.reviewboard.kde.org/r/125649/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9 with KDELibs 4.14.12 and MacPorts 2.3.4 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
> 

--===============3383115846523266230==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125649/">https://git.reviewboard.kde.org/r/125649/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Cannot test but looks good!</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">How can we ensure it's \
ported to calligra master (3.0)? Otherwise we'd loose the fixes.</p></pre>
 <br />

<p>- Jarosław Staniek</p>

<br />
<p>On October 15th, 2015, 10:55 p.m. CEST, René J.V. Bertin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and KDE Software on Mac OS X.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated Oct. 15, 2015, 10:55 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds on OS X currently generate icons for most \
Calligra applications, but those are installed only for a happy few (Krita, Braindump \
and Kexi). The other applications require an explicit install command of the \
generated <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">.icns</code> file into the app bundle's \
Resources directory.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The attached patch takes care of \
that.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In addition, it corrects the picture source \
directories for calligragemini and calligraauthor so those applications can have \
icons on other platforms too, and replaces the <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Q_WS_MACOS</code> token with the (IMHO) more appropriate <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">APPLE</code> token.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9 with KDELibs 4.14.12 and MacPorts 2.3.4 \
.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>flow/part/CMakeLists.txt <span style="color: grey">(58882f1)</span></li>

 <li>gemini/CMakeLists.txt <span style="color: grey">(85123fa)</span></li>

 <li>karbon/CMakeLists.txt <span style="color: grey">(b574779)</span></li>

 <li>plan/CMakeLists.txt <span style="color: grey">(ad39f57)</span></li>

 <li>sheets/CMakeLists.txt <span style="color: grey">(b0cc134)</span></li>

 <li>stage/app/CMakeLists.txt <span style="color: grey">(079bece)</span></li>

 <li>words/app/CMakeLists.txt <span style="color: grey">(1e73971)</span></li>

 <li>words/part/CMakeLists.txt <span style="color: grey">(9143176)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125649/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3383115846523266230==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac

[prev in list] [next in list] [prev in thread] [next in thread] 