[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Android(Chromebook) Build - USI Pen Right Click support
From: Sharaf Zaman <sharafzaz121 () gmail ! com>
Date: 2020-12-29 8:42:48
Message-ID: CAMqNc5GPWWRSKUXH=tvj_33GZT0aiDZ0RHvct5HsVTTsiMKdaw () mail ! gmail ! com
[Download RAW message or body]
Hi!
You could try to cherry-pick e2d74286
<https://invent.kde.org/szaman/krita/commit/e2d742866021a32409074031655f9ef62e3136f4>
to see if this fixes the problem. You might have to rebuild Qt.
On Tue, Dec 29, 2020 at 1:43 PM Sharaf Zaman <sharafzaz121@gmail.com> wrote:
> Hi!
>
> > - Can someone confirm why USI Pen right click does not work? Is the too
> low Android API level a reasonable root cause?
>
> I took a quick look at the code, we don't handle the case where the button
> would be BUTTON_SECONDARY (Right click) in Qt. A simple general `else`
> handling would fix the problem :)
>
> > - Is there a different instruction I can follow to rebuild Krita for
> Android?
>
> Instructions to build haven't changed, besides that we build with API
> level 23. The reason you get an error is because the checkout 4.4.1 uses a
> different way to build kf5 which recently broke. Try 4.4.2-beta2, it should
> build fine.
>
>
> On Mon, Dec 28, 2020 at 9:12 PM Rafał Sontowski <rafal.sont@gmail.com>
> wrote:
>
>> Hello,
>>
>> I recently started using Krita on Chromebook with USI Pen support (Acer
>> Chromebook Spin 713). Even in Beta Krita already is the best drawing
>> application available on Chromebook! It is a pleasure to use it with a USI
>> Pen with pressure supported.
>>
>> *Problem* - Krita does not recognize USI Pen right click, or to be
>> strict - Krita does not recognize right click when I touch the canvas with
>> USI Pen having Pen button pressed (this works as right click in other apps)
>> - hence I cannot change the drawing tool using tools wheel :(.
>>
>> *Potential root cause*: support for USI Pen buttons has been added in
>> Android 6.0 (API 23) -
>> https://developer.android.com/about/versions/marshmallow/android-6.0#bluetooth-stylus,
>> Looks like Krita for Android(and Chromebooks) is build with Android API 21,
>> or 22 (at least this is what I found in building instructions)
>>
>> I tried to rebuild Krita myself to check if the statement above is
>> correct. I am new to building KDE applications and I failed :(. I was able
>> to build Krita for Linux fine, by following instructions from
>> https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-linux,
>> but failed to build Krita for Android following
>> https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-android
>> It stopped while building few kf5 components due to QT versions mismatch:
>> {code}
>> CMake Error at CMakeLists.txt:15 (find_package):
>> Could not find a configuration file for package "Qt5" that is compatible
>> with requested version "5.14.0".
>>
>> The following configuration files were considered but not accepted:
>>
>> /home/appimage/build/i/lib/cmake/Qt5/Qt5Config.cmake, version: 5.12.9
>> {code}
>> I used "git clone / git checkout tags/4.4.1" to get sources. I faced the
>> same problem while I was trying to use Docker container for building as
>> described at:
>> https://docs.krita.org/en/untranslatable_pages/building/build_krita_with_docker_on_linux.html
>>
>> *Questions*:
>> - Can someone confirm why USI Pen right click does not work? Is the too
>> low Android API level a reasonable root cause?
>> - Is there a different instruction I can follow to rebuild Krita for
>> Android?
>>
>> regards, Rafał
>>
>>
>>
>
> --
> Kind Regards,
> Sharaf Zaman
> https://www.sh-zam.com
>
--
Kind Regards,
Sharaf Zaman
https://www.sh-zam.com
[Attachment #3 (text/html)]
<div dir="ltr"><div>Hi!</div><div><br></div><div>You could try to cherry-pick <a \
href="https://invent.kde.org/szaman/krita/commit/e2d742866021a32409074031655f9ef62e3136f4">e2d74286</a> \
to see if this fixes the problem. You might have to rebuild \
Qt.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Tue, Dec 29, 2020 at 1:43 PM Sharaf Zaman <<a \
href="mailto:sharafzaz121@gmail.com">sharafzaz121@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr"><div>Hi!</div><div><br></div><div>> - Can someone confirm why USI Pen \
right click does not work? Is the too low Android API level a reasonable root cause? \
<br></div><div><br></div><div>I took a quick look at the code, we don't handle \
the case where the button would be BUTTON_SECONDARY (Right click) in Qt. A simple \
general `else` handling would fix the problem :)</div><div><br></div><div>> - Is \
there a different instruction I can follow to rebuild Krita for Android? \
<br></div><div><br></div><div>Instructions to build haven't changed, besides that \
we build with API level 23. The reason you get an error is because the checkout 4.4.1 \
uses a different way to build kf5 which recently broke. Try 4.4.2-beta2, it should \
build fine.<br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Mon, Dec 28, 2020 at 9:12 PM Rafał Sontowski <<a \
href="mailto:rafal.sont@gmail.com" target="_blank">rafal.sont@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hello, \
<div><br><div>I recently started using Krita on Chromebook with USI Pen support (Acer \
Chromebook Spin 713). Even in Beta Krita already is the best drawing application \
available on Chromebook! It is a pleasure to use it with a USI Pen with pressure \
supported.</div><div><br></div><div><b>Problem</b> - Krita does not recognize USI Pen \
right click, or to be strict - Krita does not recognize right click when I touch the \
canvas with USI Pen having Pen button pressed (this works as right click in other \
apps) - hence I cannot change the drawing tool using tools wheel \
:(.</div><div><br></div><div><b>Potential root cause</b>: support for USI Pen buttons \
has been added in Android 6.0 (API 23) - <span \
style="background-color:unset;color:unset;font-family:"Roboto \
Mono",monospace;font-size:unset;font-variant-ligatures:unset;font-variant-caps:un \
set;font-weight:unset;letter-spacing:unset;text-align:unset;text-decoration-line:unset;text-indent:unset;text-transform:unset;word-spacing:unset"><a \
href="https://developer.android.com/about/versions/marshmallow/android-6.0#bluetooth-stylus" \
target="_blank">https://developer.android.com/about/versions/marshmallow/android-6.0#bluetooth-stylus</a></span>, \
Looks like Krita for Android(and Chromebooks) is build with Android API 21, or 22 (at \
least this is what I found in building instructions)</div><div><br></div><div>I tried \
to rebuild Krita myself to check if the statement above is correct. I am new to \
building KDE applications and I failed :(. I was able to build Krita for Linux fine, \
by following instructions from <a \
href="https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-linux" \
target="_blank">https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-linux</a>, \
but failed to build Krita for Android following <a \
href="https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-android" \
target="_blank">https://docs.krita.org/en/untranslatable_pages/building_krita.html#building-on-android</a></div><div>It \
stopped while building few kf5 components due to QT versions \
mismatch:<br></div><div>{code}</div><div><span style="font-family:monospace"><span \
style="color:rgb(0,0,0)">CMake Error at CMakeLists.txt:15 (find_package): \
</span><br>Could not find a configuration file for package "Qt5" that is \
compatible <br>with requested version "5.14.0".
<br>
<br>The following configuration files were considered but not accepted:
<br>
<br>/home/appimage/build/i/lib/cmake/Qt5/Qt5Config.cmake, version: \
5.12.9<br></span></div><div>{code}</div><div>I used "git clone / git checkout \
tags/4.4.1" to get sources. I faced the same problem while I was trying to use \
Docker container for building as described at: <a \
href="https://docs.krita.org/en/untranslatable_pages/building/build_krita_with_docker_on_linux.html" \
target="_blank">https://docs.krita.org/en/untranslatable_pages/building/build_krita_wi \
th_docker_on_linux.html</a></div><div><br></div><div><b>Questions</b>:</div><div>- \
Can someone confirm why USI Pen right click does not work? Is the too low Android \
API level a reasonable root cause? </div><div>- Is there a different instruction I \
can follow to rebuild Krita for Android? </div><div><br></div><div>regards, \
Rafał</div><div><br></div><div><br></div></div></div> </blockquote></div><br \
clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr">Kind \
Regards,<div>Sharaf Zaman</div><div><a href="https://www.sh-zam.com" \
target="_blank">https://www.sh-zam.com</a><br></div></div></div></div></div> \
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" \
class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Kind Regards,<div>Sharaf \
Zaman</div><div><a href="https://www.sh-zam.com" \
target="_blank">https://www.sh-zam.com</a><br></div></div></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic