[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    [krita/krita/4.1] libs/ui/tests: Make the KisDerivedResources test fail properly
From:       Boudewijn Rempt <null () kde ! org>
Date:       2018-07-26 15:06:11
Message-ID: E1fihqF-0004bJ-MA () code ! kde ! org
[Download RAW message or body]

Git commit 3617fd87340a5c7a793c8d03b9f4ab9f63e6ed4b by Boudewijn Rempt.
Committed on 26/07/2018 at 14:54.
Pushed by rempt into branch 'krita/4.1'.

Make the KisDerivedResources test fail properly

It crashed because of an assert in boost when checking for the
opengl version, which is totally irrelevant. So disable opengl
using KisConfig.

This now shows a probable bug:

FAIL!  : KisDerivedResourcesTest::test() Compared values are not the same
   Actual   (spy[2][0].toInt())                              : 6012
   Expected ((int)KisCanvasResourceProvider::LodAvailability): 6010
   Loc: [/home/boud/dev/krita/libs/ui/tests/kis_derived_resources_test.cpp(=
114)]

CCMAIL:kimageshop@kde.org

M  +4    -1    libs/ui/tests/kis_derived_resources_test.cpp

https://commits.kde.org/krita/3617fd87340a5c7a793c8d03b9f4ab9f63e6ed4b

diff --git a/libs/ui/tests/kis_derived_resources_test.cpp b/libs/ui/tests/k=
is_derived_resources_test.cpp
index 81381ae948e..13ffb0f3c5c 100644
--- a/libs/ui/tests/kis_derived_resources_test.cpp
+++ b/libs/ui/tests/kis_derived_resources_test.cpp
@@ -34,7 +34,7 @@
 #include <KisViewManager.h>
 #include <kis_paintop_settings.h>
 #include <KoResourcePaths.h>
-
+#include <kis_config.h>
 #include "testutil.h"
 =

 void addResourceTypes()
@@ -64,6 +64,9 @@ void addResourceTypes()
     KoResourcePaths::addResourceType("ko_effects", "data", "/effects/");
     KoResourcePaths::addResourceType("tags", "data", "/tags/");
 =

+    KisConfig cfg(false);
+    cfg.setUseOpenGL(false);
+
 }
 =

 =


[prev in list] [next in list] [prev in thread] [next in thread]