[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: Changes to Phabricator review subscriptions
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2018-05-11 14:34:49
Message-ID: CAEkBSfXG7zzkdvwwJWbUKTKmfzVG8dozY6bKh1L6gy2QRfx3Fw () mail ! gmail ! com
[Download RAW message or body]
Hi, Ben!
Thank you for clarification! I will try to configure Herald rules for that!
---
Dmitry Kazakov
11 =D0=BC=D0=B0=D1=8F 2018 =D0=B3. 12:45 =D0=9F=D0=9F =D0=BF=D0=BE=D0=BB=D1=
=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Ben Cooksley" <bcooksl=
ey@kde.org>
=D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
On Fri, May 11, 2018 at 8:25 PM, Dmitry Kazakov <dimula73@gmail.com> wrote:
> Hi, Ben!
Hi Dmitry,
>
> There is a small problem with not-subscribing Differential Revisions to
> projects: one cannot use Phabricator's Dashboard functionality for
filtering
> the incoming revisions. Is there any way to configure dashboard's
Revisions
> panel to all diffs related to a specific repository?
>
> Here is my default dashboard:
> https://phabricator.kde.org/home/menu/view/289/
You'll want to configure a search something like this -
https://phabricator.kde.org/differential/query/Q9pbWWtsYuN./#R
Please note that as Krita did not have any Herald rules previously,
this isn't something which has changed for you - it's always been this
way.
>
> In the central part it shows revisions for all the projects I'm a member
of.
> If some person creates a diff against Krita repository, but doesn't add
> #krita project to it, I will **not** see this diff in the list. Is there
> some workaround to it?
The view you're showing there is a bucketed one, meaning it only cares
about the reviews for which you are a reviewer, or the submitter, of
the review.
The solution to this (and likely other projects which have a small
group of core developers who do the reviews) is probably to have
Herald add the responsible developers as reviewers.
Subscribing whole projects didn't have this effect - it just sent
everyone in the project a notification about it.
>
> In the attachment you can find a screenshot of the panel when I'm logged
in.
>
> --
> Dmitry Kazakov
>
Regards,
Ben
[Attachment #3 (text/html)]
<div dir="auto">Hi, Ben!<div dir="auto"><br></div><div dir="auto">Thank you for \
clarification! I will try to configure Herald rules for that!</div><div \
dir="auto"><br><div data-smartmail="gmail_signature" dir="auto">---<br>Dmitry \
Kazakov</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">11 \
мая 2018 г. 12:45 ПП пользователь "Ben Cooksley" <<a \
href="mailto:bcooksley@kde.org">bcooksley@kde.org</a>> написал:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">On Fri, May 11, 2018 at 8:25 PM, Dmitry Kazakov <<a \
href="mailto:dimula73@gmail.com" target="_blank" \
rel="noreferrer">dimula73@gmail.com</a>> wrote:<br> > Hi, Ben!<br>
<br>
Hi Dmitry,<div class="quoted-text"><br>
<br>
><br>
> There is a small problem with not-subscribing Differential Revisions to<br>
> projects: one cannot use Phabricator's Dashboard functionality for \
filtering<br> > the incoming revisions. Is there any way to configure \
dashboard's Revisions<br> > panel to all diffs related to a specific \
repository?<br> ><br>
> Here is my default dashboard:<br>
> <a href="https://phabricator.kde.org/home/menu/view/289/" rel="noreferrer \
noreferrer" target="_blank">https://phabricator.kde.org/home/menu/view/289/</a><br> \
<br></div> You'll want to configure a search something like this -<br>
<a href="https://phabricator.kde.org/differential/query/Q9pbWWtsYuN./#R" \
rel="noreferrer noreferrer" \
target="_blank">https://phabricator.kde.org/differential/query/Q9pbWWtsYuN./#R</a><br>
<br>
Please note that as Krita did not have any Herald rules previously,<br>
this isn't something which has changed for you - it's always been this<br>
way.<div class="quoted-text"><br>
<br>
><br>
> In the central part it shows revisions for all the projects I'm a member \
of.<br> > If some person creates a diff against Krita repository, but doesn't \
add<br> > #krita project to it, I will **not** see this diff in the list. Is \
there<br> > some workaround to it?<br>
<br></div>
The view you're showing there is a bucketed one, meaning it only cares<br>
about the reviews for which you are a reviewer, or the submitter, of<br>
the review.<br>
The solution to this (and likely other projects which have a small<br>
group of core developers who do the reviews) is probably to have<br>
Herald add the responsible developers as reviewers.<br>
<br>
Subscribing whole projects didn't have this effect - it just sent<br>
everyone in the project a notification about it.<div class="quoted-text"><br>
<br>
><br>
> In the attachment you can find a screenshot of the panel when I'm logged \
in.<br> ><br>
> --<br>
> Dmitry Kazakov<br>
><br>
<br></div>
Regards,<br>
Ben<br>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic