[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    [calligra] krita/ui/input/wintab: [CRITICAL] Fix bug that randomly disables Krita tablet support
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2014-08-23 13:46:49
Message-ID: E1XLBeb-0000mT-EO () scm ! kde ! org
[Download RAW message or body]

Git commit 20fedc96dd59430f6ec573563e27e3bf9bd32b4b by Dmitry Kazakov.
Committed on 23/08/2014 at 13:45.
Pushed by dkazakov into branch 'master'.

[CRITICAL] Fix bug that randomly disables Krita tablet support

There was an uninitialized variable that caused updateAxesData() randomly
disable Krita tablet suport. That caused the stylus to freeze randomly
until the next Leave/Enter pair.

Workaround: if you see this bug and cannot update, just restart Krita until
you don't have this behavior. If you don't have it right after the start,
then the variable was (randomly) initialized "correctly".

CC:kimageshop@kde.org

M  +1    -2    krita/ui/input/wintab/kis_tablet_support.h

http://commits.kde.org/calligra/20fedc96dd59430f6ec573563e27e3bf9bd32b4b

diff --git a/krita/ui/input/wintab/kis_tablet_support.h b/krita/ui/input/wintab/kis_tablet_support.h
index fcb0548..2fc363a 100644
--- a/krita/ui/input/wintab/kis_tablet_support.h
+++ b/krita/ui/input/wintab/kis_tablet_support.h
@@ -158,12 +158,11 @@ struct QTabletDeviceData
                 m_axis_data[m_x11_to_local_axis_mapping[dstIt]] = axes[srcIt];
             }
 
-            return firstAxis <= m_lastSaneAxis;
+            return true;
         }
     private:
         int m_axis_data[NAxes];
         QVector<AxesIndexes> m_x11_to_local_axis_mapping;
-        int m_lastSaneAxis;
     };
 
     SavedAxesData savedAxesData;
_______________________________________________
Krita mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]