[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra/krita-iterators2-rempt] krita/image/tiles3: Handle the situation where the ng iterator
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2012-04-27 8:10:20
Message-ID: 201204271010.20647.boud () valdyas ! org
[Download RAW message or body]

On Thursday 26 April 2012 Apr, Cyrille Berger Skott wrote:
> On Thursday 26 Apr 2012, Boudewijn Rempt wrote:
> > One other idea I had today was make the createIterator methods in
> > KisPaintDevice return 0 if there's nothing to iterate over. After all, we
> > pass shared pointers to iterators around now, so that makes it already
> > actually necessary for the code to check whether we've got a real
> > iterator.
> I am not sure if I see the benefit. Instead of an assert, you get a crash. A 
> crash that you cannot avoid in a release build.

Well, it makes for an easy check... And it turns out that users don't get release \
builds from distributions: https://bugs.kde.org/show_bug.cgi?id=298879 -- at least \
*buntu ships with asserts enabled...

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]