[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra] krita/ui: don't even try to merge if there's nothing to merge
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2012-02-25 8:35:58
Message-ID: CAEkBSfXab2gvmXpfyLBMzthipE07PzgPbriaFkOCOdu20YJ6FQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Feb 25, 2012 at 11:31 AM, Boudewijn Rempt <boud@valdyas.org> wrote:

> On Saturday 25 February 2012 Feb, Dmitry Kazakov wrote:
> > Probably, we should be more accurate and not to check
> > !layer->prevSibling(), but introduce functions like prevLayer(). Because
> > this check doesn't cover the case when masks and layers are mixed.
>
> Possibly... This is the same check as is done in KisImage::mergeDown. I'm
> reluctant to add new api right now, though. At the moment, when merging
> down a loayer, all masks are discarded anyway.
>

In this case another masks may cause a trouble: the ones which are owned by
layer's parent. Ok, just a notice.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sat, Feb 25, 2012 at 11:31 AM, Boudewijn Rempt \
<span dir="ltr">&lt;<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> <div class="im">On Saturday 25 February 2012 Feb, \
Dmitry Kazakov wrote:<br> &gt; Probably, we should be more accurate and not to \
check<br> &gt; !layer-&gt;prevSibling(), but introduce functions like prevLayer(). \
Because<br> &gt; this check doesn&#39;t cover the case when masks and layers are \
mixed.<br> <br>
</div>Possibly... This is the same check as is done in KisImage::mergeDown. I&#39;m \
reluctant to add new api right now, though. At the moment, when merging down a \
loayer, all masks are discarded anyway.<br clear="all"></blockquote> </div><br>In \
this case another masks may cause a trouble: the ones which are owned by layer&#39;s \
parent. Ok, just a notice.<br><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]