[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [calligra] krita/ui/tool: don't show outline while in color picker
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2012-02-16 6:36:20
Message-ID: CAEkBSfXu8RK7a1CB939ZhZh4Ka=oEm1Qy=+hDfDLAmF4J9EfkQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


There is an even more severe bug now: try clicking the mouse several times
when the Ctrl is pressed only once. The color picker works only once.

-    else if(mode() == KisTool::HOVER_MODE &&
> +    else if(mode() == KisTool::SECONDARY_HOVER_MODE &&
>             (event->button() == Qt::LeftButton || event->button() ==
> Qt::RightButton) &&
>             event->modifiers() & Qt::ControlModifier &&
>             !specialModifierActive()) {
>

This is somehow connected with this line. Take care of the state
transitions.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

There is an even more severe bug now: try clicking the mouse several times when the \
Ctrl is pressed only once. The color picker works only once.<br><br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">

-      else if(mode() == KisTool::HOVER_MODE &amp;&amp;<br>
+      else if(mode() == KisTool::SECONDARY_HOVER_MODE &amp;&amp;<br>
                   (event-&gt;button() == Qt::LeftButton || event-&gt;button() == \
                Qt::RightButton) &amp;&amp;<br>
                   event-&gt;modifiers() &amp; Qt::ControlModifier &amp;&amp;<br>
                   !specialModifierActive()) {<br></blockquote><div><br>This is \
somehow connected with this line. Take care of the state transitions.<br>  \
</div></div>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]