[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Replacing KisChannelFlagsWidget with ChannelModel
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-07-03 13:23:08
Message-ID: 201107031523.08555.boud () valdyas ! org
[Download RAW message or body]

On Saturday 02 July 2011 Jul, JL VT wrote:
> On Sat, Jul 2, 2011 at 10:34 AM, Sven Langkamp <sven.langkamp@gmail.com>wrote:
> 
> > On Sat, Jul 2, 2011 at 3:27 PM, JL VT <pentalis@gmail.com> wrote:
> > 
> > > Trying to fix Bug 232141 I found other problems with the layer properties,
> > > for example when setting the blue channel off it's as if deactivating the
> > > red channel, and changing red is like changing blue.
> > > 
> > > I noticed that this bug is not present in the new Channel Docker that
> > > Slangkamp made, based on his ChannelModel, and that KisChannelFlagsWidget is
> > > only used in KisDlgLayerProperties, which is the dialog for layer properties
> > > (right click --> Properties...), then one I was trying to fix.
> > > 
> > > Since the Model/View architecture is a more general solution, and I know
> > > the reversed bug affecting channels is not affecting ChannelModel, I propose
> > > renaming ChannelModel to KisChannelModel and moving it to krita/ui/ , and
> > > deleting KisChannelFlagsWidget since it is completely replaced by
> > > ChannelModel, which I plan to use in KisDlgLayerProperties (displayed in the
> > > form of a QTableView).
> > > 
> > > Thoughts?. Sounds good?, Sounds bad?.
> > > 
> > 
> > Should be easy to fix the bug. When saving the flag it needs to use the
> > channel position in the channels() list and not the index of the channel.
> > That's because the channels in the channels list are ordered as BGRA but in
> > the pixels they are RGBA.
> > 
> > Thank you for the tip on fixing the bug!. I'll do that on the meanwhile.
> 
> (but I hope the thread doesn't die here, if anyone things this is a _bad
> idea_ please speak up so I can see what's the problem).
> 

I agree with Sven that the bug in KisChannelFlagWidget is probably easy to fix, it's \
much better to use the same code everywhere, so feel free to remove it and replace it \
with Sven't ChannelModel.


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]