[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: RE: koffice/krita/image/filter
From: "Ed ." <schumifer () hotmail ! com>
Date: 2010-05-06 8:40:03
Message-ID: BAY112-W5024D1F0A9951F7D3FA00CB7F50 () phx ! gbl
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
The problem with COMPOSITE_OVER is that it is additive. So instead of copying the \
filter result to the paint device, it overlays it over the original. That yields \
incorrect results when then the alpha channel is not totally opaque.
> From: cberger@cberger.net
> To: dimula73@gmail.com
> Subject: Re: koffice/krita/image/filter
> Date: Thu, 6 May 2010 10:26:42 +0200
> CC: kimageshop@kde.org
>
> On Thursday 06 May 2010, you wrote:
> > On Thu, May 6, 2010 at 1:26 AM, Cyrille Berger wrote:
> > > Hello,
> > >
> > > I am confused by this change, why remove the bitBlt with selection ?
> >
> > Well, yes. It's not clean form the point that we are going to remove
> > selections from filters. You are right.
> hum indeed. So at least I can backport.
>
> > But in this very case the code does nothing, because COMPOSITE_COPY still
> > does not take selections into account. I think we need a special composite
> > for this. Do we have one?
> Remind me why COMPOSITE_OVER does not work ? The commit message that changed
> it to COPY does not explain why...
> Because I have no clue what a COMPOSITE_COPY would do with selection. I can
> understand what happen when SELECTION = 0 or SELECTION = 255, but the result
> is totally undefined between those two values.
>
> And anyway, COMPOSITE_OVER would do what I would expect for that use.
>
> --
> Cyrille Berger
> _______________________________________________
> kimageshop mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
_________________________________________________________________
Hotmail: Powerful Free email with security by Microsoft.
https://signup.live.com/signup.aspx?id=60969
[Attachment #5 (text/html)]
<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
--></style>
</head>
<body class='hmmessage'>
The problem with COMPOSITE_OVER is that it is additive. So instead of copying the \
filter result to the paint device, it overlays it over the original. That yields \
incorrect results when then the alpha channel is not totally opaque.<BR><BR>> \
From: cberger@cberger.net<BR>> To: dimula73@gmail.com<BR>> Subject: Re: \
koffice/krita/image/filter<BR>> Date: Thu, 6 May 2010 10:26:42 +0200<BR>> CC: \
kimageshop@kde.org<BR>> <BR>> On Thursday 06 May 2010, you wrote:<BR>> > \
On Thu, May 6, 2010 at 1:26 AM, Cyrille Berger wrote:<BR>> > > \
Hello,<BR>> > > <BR>> > > I am confused by this change, why remove \
the bitBlt with selection ?<BR>> > <BR>> > Well, yes. It's not clean form \
the point that we are going to remove<BR>> > selections from filters. You are \
right.<BR>> hum indeed. So at least I can backport.<BR>> <BR>> > But in \
this very case the code does nothing, because COMPOSITE_COPY still<BR>> > does \
not take selections into account. I think we need a special composite<BR>> > \
for this. Do we have one?<BR>> Remind me why COMPOSITE_OVER does not work ? The \
commit message that changed <BR>> it to COPY does not explain why...<BR>> \
Because I have no clue what a COMPOSITE_COPY would do with selection. I can <BR>> \
understand what happen when SELECTION = 0 or SELECTION = 255, but the result <BR>> \
is totally undefined between those two values.<BR>> <BR>> And anyway, \
COMPOSITE_OVER would do what I would expect for that use.<BR>> <BR>> -- \
<BR>> Cyrille Berger<BR>> \
_______________________________________________<BR>> kimageshop mailing \
list<BR>> kimageshop@kde.org<BR>> \
https://mail.kde.org/mailman/listinfo/kimageshop<BR> <br /><hr />Hotmail: \
Powerful Free email with security by Microsoft. <a \
href='https://signup.live.com/signup.aspx?id=60969' target='_new'>Get it \
now.</a></body> </html>
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic