[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Patch to fix selection test and mask extent
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-03-24 14:47:33
Message-ID: ae32c1ef1003240747g42438c05l51fc8a7ee4b9c0f () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hmm.. I've added these functions just recently:
http://websvn.kde.org/?view=revision&revision=1099644

The logic was the following:

extent() - is the area where the node has an influence on the result image.
In other words, it is an area, where we should update when the layer changes
it's visibility.

KisMask::extent() - works right this way. It tells the area, where selection
is. And this is right for most of the masks, except of the transparency
mask. A transparency mask changes the entire image, except of the selection.
It means that we should update everywhere, except of the selection. And if
we don't have parent, we can't do anything.

So, i think, you should fix KisSelectionTest instead to confirm this logic.
Or this logic is wrong somewhere?


On Wed, Mar 24, 2010 at 4:36 PM, Sven Langkamp <sven.langkamp@gmail.com>wrote:

> Hi,
>
> I have attached a patch to fix the KisSelectionTest. The problem was that
> the extent of a KisTransparencyMask without a parent is always an empty
> QRect,
> Now the code from KisMask is used that uses the selection extent when there
> is a selection.
>
> Can you have a look if that is correct?
>
>
> Sven
>
> _______________________________________________
> kimageshop mailing list
> kimageshop@kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>


-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<div class="gmail_quote">Hmm.. I&#39;ve added these functions just recently: <a \
href="http://websvn.kde.org/?view=revision&amp;revision=1099644">http://websvn.kde.org/?view=revision&amp;revision=1099644</a><br><br>The \
logic was the following:<br> <br>extent() - is the area where the node has an \
influence on the result image. In other words, it is an area, where we should update \
when the layer changes it&#39;s visibility.<br><br>KisMask::extent() - works right \
this way. It tells the area, where selection is. And this is right for most of the \
masks, except of the transparency mask. A transparency mask changes the entire image, \
except of the selection. It means that we should update everywhere, except of the \
selection. And if we don&#39;t have parent, we can&#39;t do anything.<br> <br>So, i \
think, you should fix KisSelectionTest instead to confirm this logic. Or this logic \
is wrong somewhere?<br><br><br>On Wed, Mar 24, 2010 at 4:36 PM, Sven Langkamp <span \
dir="ltr">&lt;<a href="mailto:sven.langkamp@gmail.com">sven.langkamp@gmail.com</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi,<br><br>I have \
attached a patch to fix the KisSelectionTest. The problem was that the extent of a \
KisTransparencyMask without a parent is always an empty QRect,<br> Now the code from \
KisMask is used that uses the selection extent when there is a selection.<br> <br>Can \
you have a look if that is correct?<br><font color="#888888"><br><br>Sven<br> \
</font><br>_______________________________________________<br> kimageshop mailing \
list<br> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" \
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br> \
<br></blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]