[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Slow flood fill with QPainter canvas
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-03-05 19:29:09
Message-ID: Pine.LNX.4.64.1003052028340.8914 () calcifer ! valdyas ! org
[Download RAW message or body]

On Fri, 5 Mar 2010, Dmitry Kazakov wrote:

> > the flood fill is still slow even we optimzed the filling algorithm.
> > Here is callgrind log of running krita with QPainter canvas
> > http://valdyas.org/~lukast/projection-floodfill.tar.gz<http://valdyas.org/%7Elukast/projection-floodfill.tar.gz>
> >  
> > It seems like projection or pyramids are slow or something. The flood fill
> > is
> > also slow for OpenGL canvas. I will do the valgrinding.
> > 
> > Dmitry, can you check it out?
> > 
> 
> I looked at it briefly. It seems like a plenty of time is spent to
> KisPainter::bitBlt. New data manager api should fix this. But as for the
> KisImagePyramid, i think it should be disabled for the release, as without
> threading it is not much efficient.

Isn't there still the memory issue? Allocating a whole QImage is much
worse than allocating smaller images.

Boudewijn

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]