[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Import button crash for abr
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2010-02-16 1:42:53
Message-ID: 478b087a1002151742p1707be18p2ebe2f3a0fd18897 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Feb 15, 2010 at 4:11 PM, LukasT.dev@gmail.com
<lukast.dev@gmail.com>wrote:

> Hi,
>
> there is crash when you add abr brush to the brush chooser with Import
> button
> ( It has + icon ;) ). The problem is that importResource calls
> createResource.
> The architecture is done for one file - one resource. But abr brush
> consists of
> N brushes and we handle single bitmap as resource.
>
> createResource returns KisBrush * in kis_brush_server.cpp
> There is also method createResources but it is not called when import is
> used.
> So when we createResource for abr brush, it is not handled, just gih and
> gbr
> are.
>
> Can you help me to fix it?
> I suppose Sven would know nicer solution :)
>

I have fixed the import problem. Now we override the import in the brush
server.
What doesn't work yet it removing abr brushes (disabled for abr brushes). As
the abr brushes are part of a larger collection the current way of removing
the file doesn't work,
So we can remove the whole file which also deletes other brushes or find a
way to remove the brush from the abr file.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Mon, Feb 15, 2010 at 4:11 PM, <a \
href="mailto:LukasT.dev@gmail.com">LukasT.dev@gmail.com</a> <span dir="ltr">&lt;<a \
href="mailto:lukast.dev@gmail.com">lukast.dev@gmail.com</a>&gt;</span> wrote:<br> \
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br> <br>
there is crash when you add abr brush to the brush chooser with Import button<br>
( It has + icon ;) ). The problem is that importResource calls createResource.<br>
The architecture is done for one file - one resource. But abr brush consists of<br>
N brushes and we handle single bitmap as resource.<br>
<br>
createResource returns KisBrush * in kis_brush_server.cpp<br>
There is also method createResources but it is not called when import is used.<br>
So when we createResource for abr brush, it is not handled, just gih and gbr<br>
are.<br>
<br>
Can you help me to fix it?<br>
I suppose Sven would know nicer solution :)<br>
</blockquote></div><br>I have fixed the import problem. Now we override the import in \
the brush server.<br>What doesn&#39;t work yet it removing abr brushes (disabled for \
abr brushes). As the abr brushes are part of a larger collection the current way of \
removing the file doesn&#39;t work,<br> So we can remove the whole file which also \
deletes other brushes or find a way to remove the brush from the abr file.<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]