[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: koffice/krita/image/filter
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-01-05 9:45:19
Message-ID: ae32c1ef1001050145t7fe6c9d8p1629e13a2a99e076 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Jan 5, 2010 at 1:01 AM, Edward Apap <schumifer@hotmail.com> wrote:

> SVN commit 1070110 by eapap:
>
> Use COMPOSITE_COPY when applying filter result
>
>
>  M  +1 -1      kis_filter_job.cpp
>
>
> --- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1070109:1070110
> @@ -64,7 +64,7 @@
>
>     // blt back onto the original
>     KisPainter p2(m_dev);
> -    p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_OVER));
> +    p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_COPY));
>     p2.setSelection(m_selection);
>     p2.bitBlt(m_rc.topLeft(), dst, m_rc);
>     p2.end();
>

COMPOSITE_COPY doesn't pay any attention to the selections. At least it used
to. Please check whether this patch breaks selected filter application.

-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Tue, Jan 5, 2010 at 1:01 AM, Edward Apap <span \
dir="ltr">&lt;<a href="mailto:schumifer@hotmail.com">schumifer@hotmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> SVN commit 1070110 by \
eapap:<br> <br>
Use COMPOSITE_COPY when applying filter result<br>
<br>
<br>
  M   +1 -1         kis_filter_job.cpp<br>
<br>
<br>
--- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1070109:1070110<br>
@@ -64,7 +64,7 @@<br>
<br>
       // blt back onto the original<br>
       KisPainter p2(m_dev);<br>
-      p2.setCompositeOp(m_dev-&gt;colorSpace()-&gt;compositeOp(COMPOSITE_OVER));<br>
+      p2.setCompositeOp(m_dev-&gt;colorSpace()-&gt;compositeOp(COMPOSITE_COPY));<br>
       p2.setSelection(m_selection);<br>
       p2.bitBlt(m_rc.topLeft(), dst, m_rc);<br>
       p2.end();<br>
</blockquote></div><br>COMPOSITE_COPY doesn&#39;t pay any attention to the \
selections. At least it used to. Please check whether this patch breaks selected \
filter application.<br clear="all"><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]